Update core and coreutils #681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the go.sia.tech/core and coreutils modules to their latest revisions, standardizes the ReleaseInputs API to return errors, and adds persistent locking for wallet UTXOs via SQLite migrations and new store methods.
- Bump
coreandcoreutilsversions ingo.mod - Change
ReleaseInputssignature across multiple interfaces to include anerrorreturn - Introduce
wallet_locked_utxostable, migrations, andLockUTXOs/LockedUTXOs/ReleaseUTXOsmethods in the SQLite store
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| rhp/v3/rhp.go | Updated ReleaseInputs to return error |
| rhp/v2/rhp.go | Updated ReleaseInputs to return error |
| api/api.go | Updated ReleaseInputs to return error |
| host/settings/settings.go | Updated ReleaseInputs to return error |
| host/contracts/manager.go | Updated ReleaseInputs to return error |
| internal/testutil/rhp/v3/rhp.go | Updated stub ReleaseInputs to return error |
| persist/sqlite/migrations.go | Added migrateVersion40 to create locked UTXO table |
| persist/sqlite/init.sql | Added initial schema for wallet_locked_utxos |
| persist/sqlite/wallet.go | Implemented locking/unlocking of UTXOs |
| go.mod | Bumped versions of go.sia.tech/core and coreutils |
Comments suppressed due to low confidence (1)
persist/sqlite/wallet.go:15
- New UTXO locking methods (
LockUTXOs,LockedUTXOs,ReleaseUTXOs) lack unit tests; consider adding coverage to validate locking behavior and cleanup.
func cleanupLockedUTXOs(tx *txn) error {
peterjan
reviewed
May 23, 2025
peterjan
previously approved these changes
May 23, 2025
ChrisSchinnerl
previously approved these changes
May 23, 2025
3f8e5d3 to
d18af17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates core and coreutils to the latest versions.