8000 Support for SVGs and images in theme-graph by aswamy · Pull Request #988 · Shopify/theme-tools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support for SVGs and images in theme-graph #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2025
Merged

Support for SVGs and images in theme-graph #988

merged 1 commit into from
Jun 19, 2025

Conversation

aswamy
Copy link
Contributor
@aswamy aswamy commented Jun 18, 2025 •
edited
Loading

What are you adding in this PR?

Fixes #981

  • Added support for SVGs and Images on theme-graph

Tophat

  • Check out branch
  • Press F5
  • Open a theme repo
  • Find a theme file that calls out an SVG or an image file in the assets folder
  • It should appear in the Dependencies panel
image

Before you deploy

  • I included a patch bump changeset

@aswamy aswamy requested a review from a team as a code owner June 18, 2025 20:05
@aswamy aswamy requested a review from charlespwd June 18, 2025 20:05
aswamy
aswamy commented Jun 18, 2025
View reviewed changes
EvilGenius13
EvilGenius13 approved these changes Jun 18, 2025
View reviewed changes
Copy link
Contributor
@EvilGenius13 EvilGenius13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! 🎩 'd the changes and could see dependencies including images.

charlespwd
charlespwd approved these changes Jun 19, 2025
View reviewed changes
Copy link
Contributor
@charlespwd charlespwd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design is sound!

@aswamy aswamy force-pushed the aswamy/theme-graph-svgs-images branch from c378ed2 to 23f2997 Compare June 19, 2025 18:56
@aswamy aswamy merged commit ce7c01e into main Jun 19, 2025
7 checks passed
@aswamy aswamy deleted the aswamy/theme-graph-svgs-images branch June 19, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvilGenius13 EvilGenius13 EvilGenius13 approved these changes

@charlespwd charlespwd charlespwd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

theme graph does check inline_asset_content filter
3 participants
@aswamy @charlespwd @EvilGenius13
0