8000 Fix loading custom tools by palkan · Pull Request #58 · Shopify/roast · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix loading custom tools #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

palkan
Copy link
@palkan palkan commented May 20, 2025

We try to initialize the tools specified in the workflow in the #include_tools method but currently it's called after #load_roast_initializers—so, we observe NameError-s (no constant defined). Changing the load order fixes the issues.

@dblock
Copy link
Contributor
dblock commented May 20, 2025

Thanks! Add a test for this that reproduces the NameError?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0