8000 Targetless fixes by palkan · Pull Request #57 · Shopify/roast · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Targetless fixes #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Targetless fixes #57

wants to merge 1 commit into from

Conversation

palkan
Copy link
@palkan palkan commented May 20, 2025

There are some issues I've encountered while playing with a targetless workflow:

  • null system prompt:
Chat completion failed!!!!!!!!!!!!!!!!: {"error"=>{"message"=>"Invalid value for 'content': expected a string, got null.", "type"=>"invalid_request_error", "param"=>"messages.[0].content", "code"=>nil}}

That happens when no workflow prompt exists and no target specified.

  • Saving state for targetless executions failed because there is no file_path

Fixed both in this PR.

@palkan
- various targetless fixes
04a59b1 
- Do not add null system message if no prompt and target defined

- Fix saving state for targetless executions
@dblock
Copy link
Contributor
dblock commented May 20, 2025

Thanks! Add tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@palkan @dblock
0