8000 Fix incorrect NASM install skipping logic. by tlaedre · Pull Request #26 · ShiftMediaProject/VSNASM · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix incorrect NASM install skipping logic. #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tlaedre
Copy link
Contributor
@tlaedre tlaedre commented Jul 3, 2024

Fix two issues with the skip-NASM-install-if-exists-in-%NASMPATH%-logic:

  1. Installing NASM binaries doesn't work at all (the use existing exe path is always taken, regardless of whether the env var is set or the exe exists).
  2. The skip-install path is skipped if the nasm archive has been downloaded and exists on disk.

@Sibras Sibras merged commit c511e9a into ShiftMediaProject:master Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0