8000 Implementation of vasprintf emulation by u1f992 · Pull Request #243 · SergiusTheBest/plog · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Implementation of vasprintf emulation #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 29, 2023
Merged

Implementation of vasprintf emulation #243

merged 5 commits into from
Mar 29, 2023

Conversation

u1f992
Copy link
Contributor
@u1f992 u1f992 commented Mar 19, 2023 •
edited
Loading

vasprintf for _WIN32 or non _GNU_SOURCE should be consolidated in this way.

vsnprintf here is a part of old C standards, so it will probably work in all environments that plog should support.

I've roughly confirmed that can build in the following environments, but more testing might be needed.

  • gcc/g++ MSYS2
  • VC++2022
  • Embarcadero C++Builder Community Edition
  • PlatformIO, for boards listed in platformio.ini

Related issues:

@u1f992
Copy link
Contributor Author
u1f992 commented Mar 19, 2023

It appears that the platformio-ci Docker image needs to be updated. I would appreciate it if you manage it.

@SergiusTheBest SergiusTheBest self-assigned this Mar 19, 2023
@SergiusTheBest SergiusTheBest added this to the 1.1.10 milestone Mar 19, 2023
@SergiusTheBest
Copy link
Owner

Thank you, @u1f992 !

It appears that the platformio-ci Docker image needs to be updated. I would appreciate it if you manage it.

Yes, let me take care of that.

SergiusTheBest
SergiusTheBest requested changes Mar 23, 2023
View reviewed changes
@SergiusTheBest
Copy link
Owner

I made a new image with raspberrypi platform: it's ghcr.io/sergiusthebest/platformio-ci:latest.

@u1f992
Copy link
Contributor Author
u1f992 commented Mar 26, 2023

Thank you for the update! Now it has passed all checks.

@u1f992 u1f992 changed the title Implementation of vasprintf enulation Implementation of vasprintf emulation Mar 26, 2023
@SergiusTheBest SergiusTheBest merged commit ed334c4 into SergiusTheBest:develop Mar 29, 2023
@SergiusTheBest
Copy link
Owner

@u1f992 Thank you for your contribution!

@SergiusTheBest SergiusTheBest mentioned this pull request Mar 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergiusTheBest SergiusTheBest SergiusTheBest approved these changes

Assignees

@SergiusTheBest SergiusTheBest

Labels
enhancement
Projects
None yet
Milestone
1.1.10
Development

Successfully merging this pull request may close these issues.
2 participants
@u1f992 @SergiusTheBest
0