Fix race condition in StreamHandler directory creation with locking#1967

Open

TheJoeSchr wants to merge 23 commits intoSeldaek:mainfrom

TheJoeSchr:fix/useLocking-also-lock-directory

Commits on May 17, 2025

Commits on May 18, 2025

refactor: rename lock file handle variables for clarity
TheJoeSchr
committed
feat: add retry mechanism for directory locking locking in `StreamHandler::createDir()`
TheJoeSchr
committed
fix: improve stream handler retry and locking mechanism with better comments
TheJoeSchr
committed
refactor: implement random sleep duration between retries with exponential backoff
TheJoeSchr
committed
refactor: improve retry mechanism with exponential backoff and random sleep intervals
TheJoeSchr
committed
refactor: throw exception instead of returning false in attemptOperationWithRetry
TheJoeSchr
committed
feat: also retry `fopen()` on `$lockDirectoryStream` and handle locks types differently on Windows and non-Windows systems
TheJoeSchr
committed
refactor: don't use `$parentDir`, `$lockDir` is already parent of `$lockFile`
TheJoeSchr
committed
refactor: change method name to be more specific `attemptOperationWithExponentialRandomizedRetries` => `attemptOperationWithExponentialRandomizedRetries`, Fix return type, Update PHPDoc
TheJoeSchr
committed
docs: update PHPDoc for `attemptOperationWithExponentialRandomizedRetries` to include mixed return type
TheJoeSchr
committed
refactor: change `$lockMode` according to `is_dir()`, rename `$lockFile` => `$lockRessource`
TheJoeSchr
committed
tests: tests one more subdirectory deeper and also uses DIRECTORY_SEPARATOR
TheJoeSchr
committed
refactor: improve recursive directory creation logic with better locking and error handling
TheJoeSchr
committed
fix: add try/catch block to also retry on exception in `StreamHandler()::attemptOperationWithExponentialRandomizedRetries()`
TheJoeSchr
committed
feat: increase re-try times to get more chances for successful lock `StreamHandler()::attemptOperationWithExponentialRandomizedRetries()`
TheJoeSchr
committed
fix: `StreamHandler::createDir()`: if `helperResource` is a directory, first try to `fopen()` with read/write and then read only.
TheJoeSchr
committed
fix: `StreamHandler()::write` improve stream handling with null initialization and checks before using
TheJoeSchr
committed
feat: `StreamHandler::write()` also uses `attemptOperationWithExponentialRandomizedRetries()` for stream locking
TheJoeSchr
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix race condition in StreamHandler directory creation with locking#1967

Fix race condition in StreamHandler directory creation with locking#1967
TheJoeSchr wants to merge 23 commits intoSeldaek:mainfrom
TheJoeSchr:fix/useLocking-also-lock-directory

Commits on May 17, 2025

test: add tests for useLocking in createDir method

When locking file also, lock directory in StreamHandler

Commits on May 18, 2025

refactor: rename lock file handle variables for clarity

feat: add retry mechanism for directory locking locking in `StreamHandler::createDir()`

fix: improve stream handler retry and locking mechanism with better comments

refactor: implement random sleep duration between retries with exponential backoff

refactor: improve retry mechanism with exponential backoff and random sleep intervals

refactor: throw exception instead of returning false in attemptOperationWithRetry

feat: also retry `fopen()` on `$lockDirectoryStream` and handle locks types differently on Windows and non-Windows systems

refactor: don't use `$parentDir`, `$lockDir` is already parent of `$lockFile`

refactor: change method name to be more specific `attemptOperationWithExponentialRandomizedRetries` => `attemptOperationWithExponentialRandomizedRetries`, Fix return type, Update PHPDoc

docs: update PHPDoc for `attemptOperationWithExponentialRandomizedRetries` to include mixed return type

refactor: change `$lockMode` according to `is_dir()`, rename `$lockFile` => `$lockRessource`

tests: tests one more subdirectory deeper and also uses DIRECTORY_SEPARATOR

refactor: improve recursive directory creation logic with better locking and error handling

fix: add try/catch block to also retry on exception in `StreamHandler()::attemptOperationWithExponentialRandomizedRetries()`

feat: increase re-try times to get more chances for successful lock `StreamHandler()::attemptOperationWithExponentialRandomizedRetries()`

fix: `StreamHandler::createDir()`: if `helperResource` is a directory, first try to `fopen()` with read/write and then read only.

fix: `StreamHandler()::write` improve stream handling with null initialization and checks before using

feat: `StreamHandler::write()` also uses `attemptOperationWithExponentialRandomizedRetries()` for stream locking

Commits on May 19, 2025

feat: simplify createDir logic by letting `mkdir($recursive=true)` handle recursion

test: feat: Add recursive directory cleanup method to StreamHandlerTest

feat: `StreamHandler::createDir()`: `mkdir` also uses exponential randomized retries

Uh oh!

Fix race condition in StreamHandler directory creation with locking#1967TheJoeSchr wants to merge 23 commits intoSeldaek:mainSeldaek/monolog:mainfrom TheJoeSchr:fix/useLocking-also-lock-directoryTheJoeSchr/monolog:fix/useLocking-also-lock-directoryCopy head branch name to clipboard

Commits

Commits on May 17, 2025

Commits on May 18, 2025

Commits on May 19, 2025

Fix race condition in StreamHandler directory creation with locking#1967
TheJoeSchr wants to merge 23 commits intoSeldaek:mainfrom
TheJoeSchr:fix/useLocking-also-lock-directory