Coding style docs, mostly #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemerle
pushed a commit
that referenced
this pull request
Jan 2, 2018
Sync personal master with SEGS master
eos428
pushed a commit
to eos428/Segs
that referenced
this pull request
Apr 18, 2018
- Removed declaration of zero_terminate_strings in AuthHandler.h and made it into a static function in AuthHandler.cpp - zero_terminate_strings will nullify the last character in those char arrays - on_login checks for the length of login (size 14) and password (size 16) char arrays. Should the length of those arrays be its size, there is no null termination and the program gets wonky from there - Should that happen, send in account blocked error to the client? What could be done better - Create error messages that signify if the username/password is too long or short on Server-Side if possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.