Add assertion to check for dimensionality of labels #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This assertion would have saved me almost an entire weekend of debugging. I realize this is documented in the function's comments, but if I can save the next guy that same pain, then I think it's worth checking for this.
|
Thanks for the PR man :) |
|
Thanks for the CTC implementation for PyTorch!
…On Sun, 8 Oct 2017 at 22:44 Sean Naren ***@***.***> wrote:
Thanks for the PR man :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA1d7SjWMaaid3PL-091onOTvcRwsD8yks5sqTQqgaJpZM4PxzTz>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This assertion would have saved me almost an entire weekend
of debugging! I realize this is documented in the function's
comments, but if I can save the next guy that same pain, then
I think it's worth checking for this.