-
Notifications
You must be signed in to change notification settings - Fork 296
Redirect ALL un-loadable NetCDF objects to LOAD_PROBLEMS
#6465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6465 +/- ##
==========================================
+ Coverage 89.83% 89.88% +0.04%
==========================================
Files 90 90
Lines 23820 23904 +84
Branches 4452 4459 +7
==========================================
+ Hits 21399 21485 +86
+ Misses 1670 1667 -3
- Partials 751 752 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
All reactions
Sorry, something went wrong.
lib/iris/tests/unit/fileformats/nc_load_rules/actions/test__grid_mappings.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @trexfeathers
I've reviewed up to commit 8887c69 (Cell methods) and other than a few minor comments I think this is looking ace so far. 👍
Sorry, something went wrong.
All reactions
-
👍 1 reacti 8000 on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see SciTools/.github#146
Sorry, something went wrong.
All reactions
⏱️ Performance Benchmark Report: 74a3371Performance shifts
Full benchmark results
Generated by GHA run |
All reactions
Sorry, something went wrong.
lib/iris/tests/unit/fileformats/nc_load_rules/helpers/test_build_and_add_names.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome work - especially as its not as simple to implement in some places as we might have first thought. Nice one @trexfeathers! 💯
LGTM!
Sorry, something went wrong.
All reactions
Issue SciTools/.github#146 raised by scitools-ci[bot] for templated file change.
ukmo-ccbunney
scitools-ci[bot]
Successfully merging this pull request may close these issues.
Capture ALL un-loadable NetCDF objects
🚀 Pull Request
Description
Closes #6319
Objects
LoadProblems.Problem.handled
flagLoadProblems.Problem.destination
attribute, for maximum contextRefactor existing changes to capture objects being added to non-Cube
objects tooConsult Iris pull request check list
Add any of the below labels to trigger actions on this PR: