This repository was archived by the owner on Feb 17, 2023. It is now read-only.
Preserve mask through math operations #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| def test_single_argument_operation(self): | ||
| actual = Elementwise(self.masked_array, None, np.abs, ma.abs) | ||
| assert_array_equal(actual.masked_array().mask, self.mask) |
There was a problem hiding this comment.
We need to test the data here too.
There was a problem hiding this comment.
Evidently I'm now used to never testing actual numbers 😉
|
Great fix! Thanks @dkillick. The only change is to the tests (to ensure the numbers are correct). 👍 |
|
Now with numbers tests too. |
pelson
added a commit
that referenced
this pull request
Nov 20, 2015
Preserve mask through math operations
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to
2EF1
a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure masked arrays are handled correctly (i.e. the mask is preserved) when performing mathematical operations using biggus operation functions such as
biggus.log10orbiggus.power.Fixes #166.