8000 Support parRF using rf hyperparams by kelly-sovacool · Pull Request #306 · SchlossLab/mikropml · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support parRF using rf hyperparams #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Nov 1, 2022
Merged

Support parRF using rf hyperparams #306

merged 12 commits into from
Nov 1, 2022

Conversation

kelly-sovacool
Copy link
Member
@kelly-sovacool kelly-sovacool commented Oct 24, 2022 •
edited
Loading

parRF is a parallel implementation of the rf method in caret. It uses the same underlying randomForest package and thus has the same hyperparameters.

Issues

Change(s) made

  • Use the same default hyperparameters for parRF as rf.
  • Throw an error if an unsupported method is specified without custom hyperparameters, and don't warn if custom hyperparameters are given.
  • Added explanation for using unsupported methods with custom hyperparameters in the tuning vignette.

Checklist

(Strikethrough any points that are not applicable.)

  • Write unit tests for any new functionality or bug fixes.
  • Update docs if there are any API changes:
    • [ ] roxygen comments
    • vignettes
  • Update NEWS.md if this includes any user-facing changes.
  • The check workflow succeeds on your most recent commit. This is always required before the PR can be merged.

@kelly-sovacool kelly-sovacool requested review from a team and courtneyarmour and removed request for a team October 24, 2022 15:44
@kelly-sovacool kelly-sovacool marked this pull request as ready for review October 24, 2022 17:08
@kelly-sovacool kelly-sovacool merged commit 42d4298 into main Nov 1, 2022
@kelly-sovacool kelly-sovacool deleted the parRF branch November 1, 2022 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@courtneyarmour courtneyarmour courtneyarmour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use hyperparams from rf for parRF
2 participants
@kelly-sovacool @courtneyarmour
0