Forward extra arguments to caret::train()
#304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run_ml() & train_model() to forward extra arguments to caret::train()caret::train()
Codecov ReportBase: 98.09% // Head: 98.09% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #304 +/- ##
=======================================
Coverage 98.09% 98.09%
=======================================
Files 13 13
Lines 995 999 +4
=======================================
+ Hits 976 980 +4
Misses 19 19
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
sklucas
approved these changes
Oct 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run_ml()now forwards extra arguments (...) totrain_model(), which then forwards them tocaret::train(). This allows our users to take advantage of specialty arguments used by specific model engines such asntreeforrfandweightsforglmnet(among other models that accept case weights), even when we haven't explicitly defined them inrun_ml().To implement this, I had to switch from formula notation to x,y notation. We had wanted to do that anyway to prevent #156. However, formula notation is still used for support vector machines to circumvent a problem in
kernlab(see this comment in caret iss #809).Issues
Change(s) made
...) tocaret::train().ntreeargument fromrun_ml()andtrain_model(), since that is now captured by....weightsargument is used when given forglmnet.train_model().caret::train()for svm models.caret::train()for all others.Checklist
(
Strikethroughany points that are not applicable.)ntreeis not one of the named arguments inrun_ml()but can still be defined and used forrf.NEWS.mdif this includes any user-facing changes.