Update tests to use the 3rd edition of testthat #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expect_message returns the message object now, so expectations like expect_equal have to be nested inside it in order to work.
instead of expect_equivalent(). Also, handle multiple deprecation warnings.
|
The check is throwing a warning because gtools is an orphaned package, and one of mikropml's indirectly depends on it -- I think the root package is BayesFactor. Waiting on them to submit a new release to CRAN richarddmorey/BayesFactor#161 |
|
I determined which mikropml dependencies depend on gtools with: mikropml_deps <- tools::package_dependencies(packages = 'mikropml',
recursive = TRUE)$mikropml %>%
sort()
all_deps <- tools::package_dependencies(packages = mikropml_deps,
recursive = TRUE)
deps_tbl <- tibble::tibble(Package=names(all_deps),
data=purrr::map(all_deps, tibble::as_tibble)) %>%
tidyr::unnest(data)
deps_tbl %>% dplyr::filter(value == 'gtools') %>% knitr::kable()
gplots depends on gtools, while ROCR depends on gplots and MLmetrics depends on ROCR. So gplots is the root cause. I opened an issue here: talgalili/gplots#11 |
|
For future reference, |
…into testthat-3e
|
macOS devel seems to be failing due to an error beyond our control. I think we can move forward with this as-is. |
sklucas
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://testthat.r-lib.org/articles/third-edition.html
Change(s) made
DESCRIPTIONgtoolsbecame orphaned, but that has now been fixed.Checklist
(
Strikethroughany points that are not applicable.)[ ] Write unit tests for any new functionality or bug fixes.[ ] Update docs if there are any API changes:[ ] roxygen comments[ ] vignettes[ ] UpdateNEWS.mdif this includes any user-facing changes.