8000 Bump ocaml to 4.08 by tatchi · Pull Request #192 · Schniz/fnm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bump ocaml to 4.08 #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 25, 2020
Merged

Bump ocaml to 4.08 #192

merged 3 commits into from
Feb 25, 2020

Conversation

tatchi
Copy link
Contributor
@tatchi tatchi commented Feb 19, 2020

I updated OCaml to 4.08. I had also to update two others dependencies (base and ppx_let).

First time I do that so let's see if the CI pass 😆

@tatchi
Copy link
Contributor Author
tatchi commented Feb 19, 2020 •
edited
Loading

It failed on Linux:

docker: Error response from daemon: pull access denied for schlez/fnm-static-binary, repository does not exist or may require 'docker login': denied: requested access to the resource is denied.

@Schniz Do you have any idea ?

@Schniz
Copy link
Owner
Schniz commented Feb 20, 2020

@Schniz Do you have any idea ?

The docker image creation has failed. The .ci/create-static-binary.sh script that I wrote does not have set -e on the top, making failed commands just continue instead of failing the whole script

@tatchi
Copy link
Contributor Author
tatchi commented Feb 21, 2020

Youhhhouu 🎉🤗

@tatchi tatchi requested a review from Schniz February 21, 2020 17:37
@Schniz Schniz added the PR: Internal An internal work has been made label Feb 25, 2020
@Schniz Schniz merged commit 83e9168 into Schniz:master Feb 25, 2020
@Schniz
Copy link
Owner
Schniz commented Feb 25, 2020

Thanks @tatchi! 🤑 🌮

@tatchi tatchi deleted the update-ocaml branch February 25, 2020 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Schniz Schniz Awaiting requested review from Schniz

Assignees
No one assigned
Labels
PR: Internal An internal work has been made
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tatchi @Schniz
0