UX Use add-file icon for adding files instead of add #160
Conversation
* free the place to add a new `$(add)` that adds custom var/secret names
|
The doc screenshots icons might be required to be altered, but I would hold eventually for adding add back to create an item? What do you think? |
Yes the doc screenshots will need to be updated, but I can take a look at doing that after I make a couple more updates to a few things. As for adding a |
if your detection could would be bullet proof maybe yes. GitHub has a js lib on npm to parse workflows and do it better Just one single example There are billions |
|
e.g. How would you add the possible runners? It's complex, yes actrc is always possible |
Yes, the simple regex I have definitely needs improvements to better extract vars, secrets, etc. I already know of two issues with the current regex (#66, #58). I am hoping tho to better improve this parsing rather than having to rely on the user to manually add items.
Can you share what the library is for this? Can it be used to easily extract out the vars, secrets, inputs, etc?
For matrices, I agree the support is not perfect right now. I am even thinking if it would be a good idea to add a |
Yes should help for all expression named values
Those packages are somewhat weird if it comes to imports, e.g. a bundler is required or they throw weird stuff as node doesn't accept them as they are published.
Didn't check this |
Thanks for the suggestions. Opened #163 to track looking into this |
I'm not a UX expert, but this confused me a bit
✍ Changes
Don't require to hover the
+icon to realize this creates a file and instead of allowing to add an entryFree the place to add a new
$(add)that adds custom var/secret names.📋 Checklist