Lock rust version #105
Merged
Lock rust version #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinacahalan
pushed a commit
that referenced
this pull request
Jan 30, 2023
This locks the rust version to the most recent available (1.67.0). Future releases will be ignored by GitHub Actions until this version is manually updated. The rust-toolchain.toml file also forces clients to have the specific version of the toolchain for the project to avoid compatibility issues. In addition, the GitHub Action for installing the rust toolchain has been replaced with `rustup show`. The action is no longer actively developed as of the time of commit and does not fully support reading from the rust-toolchain.toml file from testing. While the functionality of `rustup show` installing from the toolchain file is not documented well, it will at the moment perform the same action. Should a proper "install the toolchain from the rust-toolchain.toml file" feature be released, this would be preferred. Finally, as a bonus, *all* tests in check.yml will now run regardless of how each test completed. This, for example, allows for testing the build of the project even if there was a small formatting issue reported by `cargo fmt`. Previously, a formatting issue would have stopped all checking and possibly hide other problems that could be fixed at the same time.
kevinacahalan
added a commit
that referenced
this pull request
Jan 30, 2023
* Added initial stuff to implement the J instruction * datapath: Add reset() * Console and regview branch (#104) * made some boxes basic stuff * aside * add float to move it right * making table * dynamic size * using better units * Create tabs.rs * screen fitting * resolve merge conflict * resolve merge conflict 2 * progress on regview * changed according to clippy * update * reformatted - clippy * Lock rust version (#105) This locks the rust version to the most recent available (1.67.0). Future releases will be ignored by GitHub Actions until this version is manually updated. The rust-toolchain.toml file also forces clients to have the specific version of the toolchain for the project to avoid compatibility issues. In addition, the GitHub Action for installing the rust toolchain has been replaced with `rustup show`. The action is no longer actively developed as of the time of commit and does not fully support reading from the rust-toolchain.toml file from testing. While the functionality of `rustup show` installing from the toolchain file is not documented well, it will at the moment perform the same action. Should a proper "install the toolchain from the rust-toolchain.toml file" feature be released, this would be preferred. Finally, as a bonus, *all* tests in check.yml will now run regardless of how each test completed. This, for example, allows for testing the build of the project even if there was a small formatting issue reported by `cargo fmt`. Previously, a formatting issue would have stopped all checking and possibly hide other problems that could be fixed at the same time. * Add more to pipline for J support * Completed calculation of jump address * Implemented the J instruction Need to write test cases * Actually implemented the J instruction, for real * Wrote basic test case for jump instruction * Done J instruction tests * Increased memory size to 64k * Update src/emulation_core/mips/datapath.rs Co-authored-by: Jerrett Longworth <jerrett7@gmail.com> --------- Co-authored-by: Jerrett Longworth <jerrett7@gmail.com> Co-authored-by: huynguyen2019 <60188307+huynguyen2019@users.noreply.github.com>
kevinacahalan
added a commit
that referenced
this pull request
Jan 30, 2023
* Added initial stuff to implement the J instruction * datapath: Add reset() * Console and regview branch (#104) * made some boxes basic stuff * aside * add float to move it right * making table * dynamic size * using better units * Create tabs.rs * screen fitting * resolve merge conflict * resolve merge conflict 2 * progress on regview * changed according to clippy * update * reformatted - clippy * Lock rust version (#105) This locks the rust version to the most recent available (1.67.0). Future releases will be ignored by GitHub Actions until this version is manually updated. The rust-toolchain.toml file also forces clients to have the specific version of the toolchain for the project to avoid compatibility issues. In addition, the GitHub Action for installing the rust toolchain has been replaced with `rustup show`. The action is no longer actively developed as of the time of commit and does not fully support reading from the rust-toolchain.toml file from testing. While the functionality of `rustup show` installing from the toolchain file is not documented well, it will at the moment perform the same action. Should a proper "install the toolchain from the rust-toolchain.toml file" feature be released, this would be preferred. Finally, as a bonus, *all* tests in check.yml will now run regardless of how each test completed. This, for example, allows for testing the build of the project even if there was a small formatting issue reported by `cargo fmt`. Previously, a formatting issue would have stopped all checking and possibly hide other problems that could be fixed at the same time. * Add more to pipline for J support * Completed calculation of jump address * Implemented the J instruction Need to write test cases * Actually implemented the J instruction, for real * Wrote basic test case for jump instruction * Done J instruction tests * Increased memory size to 64k * Added AluZ datapath signal * Added branch decision stuff to datapath * Updated comment * Implemented beq and bne * Fixed bug with branch addr calc * Added branch test cases, one fails * datapath: Fix BEQ bug * Ran cargo fmt --------- Co-authored-by: Jerrett Longworth <jerrett7@gmail.com> Co-authored-by: huynguyen2019 <60188307+huynguyen2019@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.