8000 remove some svfvalue in svfcore by jumormt · Pull Request #1641 · SVF-tools/SVF · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

remove some svfvalue in svfcore #1641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2025
Merged

remove some svfvalue in svfcore #1641

merged 1 commit into from
Jan 27, 2025

Conversation

jumormt
Copy link
Contributor
@jumormt jumormt commented Jan 27, 2025

No description provided.

@@ -500,11 +497,6 @@ class CondPTAImpl : public PointerAnalysis
return objToNSRevPtsMap[obj];
}

/// Interface expose to users of our pointer analysis, given Value infos
virtual inline AliasResult alias(const SVFValue* V1, const SVFValue* V2)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to keep SVFVar* V1 and SVFVar* V2 api.

@@ -232,10 +232,6 @@ class PointerAnalysis
/// Compute points-to results on-demand, overridden by derived classes
virtual void computeDDAPts(NodeID) {}

/// Interface exposed to users of our pointer analysis, given Value infos
virtual AliasResult alias(const SVFValue* V1,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace SVFValue with SVFVar

8000
Copy link
codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 28.57143% with 15 lines in your changes missing coverage. Please review.

Project coverage is 63.82%. Comparing base (3eac69e) to head (6cad25c).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
svf/lib/MSSA/MemRegion.cpp 0.00% 9 Missing ⚠️
svf/include/MemoryModel/PointerAnalysisImpl.h 0.00% 4 Missing ⚠️
svf/include/DDA/DDAPass.h 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1641      +/-   ##
==========================================
+ Coverage   63.74%   63.82%   +0.07%     
==========================================
  Files         247      247              
  Lines       26054    26014      -40     
  Branches     4511     4500      -11     
==========================================
- Hits        16609    16604       -5     
+ Misses       9445     9410      -35     
Files with missing lines Coverage Δ
svf-llvm/lib/SVFIRBuilder.cpp 83.54% <100.00%> (-0.03%) ⬇️
svf/include/CFL/CFLAlias.h 92.85% <ø> (+11.60%) ⬆️
svf/include/Graphs/ConsG.h 83.33% <ø> (ø)
svf/include/Graphs/IRGraph.h 95.23% <ø> (+2.64%) ⬆️
svf/include/MSSA/MemRegion.h 87.50% <ø> (ø)
svf/include/MemoryModel/PointerAnalysis.h 77.08% <ø> (ø)
svf/include/SVFIR/SVFIR.h 90.95% <ø> (ø)
svf/include/SVFIR/SVFVariables.h 65.78% <ø> (ø)
svf/include/Util/SVFUtil.h 85.41% <ø> (ø)
svf/include/WPA/WPAPass.h 33.33% <ø> (ø)
... and 9 more

... and 2 files with indirect coverage changes

* Determine whether a const CallICFGNode* instruction can mod or ref
* a specific memory location pointed by V
*/
ModRefInfo MRGenerator::getModRefInfo(const CallICFGNode* cs, const SVFValue* V)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SVFValue* => SVFVar* V

* Return alias results based on our points-to/alias analysis
* TODO: Need to handle PartialAlias and MustAlias here.
*/
AliasResult DDAPass::alias(const SVFValue* V1, const SVFValue* V2)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SVFValue* => SVFVar* V

@jumormt
Copy link
Contributor Author
jumormt commented Jan 27, 2025

--- log/nginx.log 2025-01-27 15:55:45.574264574 +1100
+++ log/nginx-xiao.log 2025-01-27 15:56:36.945746391 +1100
@@ -39,9 +39,9 @@
VarArrayObj 153
VarStructObj 630
----------------Time and memory stats--------------------
-LLVMIRTime 1.747
-SVFIRTime 1.294
-SymbolTableTime 0.191
+LLVMIRTime 1.568
+SVFIRTime 1.149
+SymbolTableTime 0.177
#######################################################

PTACallGraph Stats (Andersen analysis)******
@@ -68,11 +68,11 @@
CollapseTime 0
CopyGepTime 0
LoadStoreTime 0
-MemoryUsageVmrss 2.32434e+06
-MemoryUsageVmsize 2.32432e+06
+MemoryUsageVmrss 2.32452e+06
+MemoryUsageVmsize 2.32435e+06
SCCDetectTime 0
SCCMergeTime 0
-TotalTime 122.928
+TotalTime 124.229
UpdateCGTime 0
----------------Numbers stats----------------------------
AddrProcessed 5909
@@ -144,11 +144,11 @@
CollapseTime 0
CopyGepTime 0
LoadStoreTime 0
-MemoryUsageVmrss 2.32907e+06
-MemoryUsageVmsize 2.32906e+06
+MemoryUsageVmrss 2.32927e+06
+MemoryUsageVmsize 2.3291e+06
SCCDetectTime 0
SCCMergeTime 0
-TotalTime 137.212
+TotalTime 138.768
UpdateCGTime 0
----------------Numbers stats----------------------------
AddrProcessed 5909
@@ -199,32 +199,32 @@
Persistent Points-To Cache Statistics: Andersen's analysis bitvector
################ (program : nginx.bc)###############
UniquePointsToSets 14762
-TotalUnions 589462
+TotalUnions 589461
PropertyUnions 149148
UniqueUnions 8201
LookupUnions 418580
-PreemptiveUnions 13533
+PreemptiveUnions 13532
TotalComplements 1731373
PropertyComplements 1381996
UniqueComplements 6543
LookupComplements 336293
PreemptiveComplements 6541
-TotalIntersections 1796737
-PropertyIntersections 1783026
-UniqueIntersections 35
-LookupIntersections 572
-PreemptiveIntersections 13104
+TotalIntersections 1796736
+PropertyIntersections 1783085
+UniqueIntersections 34
+LookupIntersections 514
+PreemptiveIntersections 13103
#######################################################

Memory SSA Statistics******
################ (program : nginx.bc)###############
----------------Time and memory stats--------------------
AverageRegSize 39.1348
-GenMUCHITime 1.24
-GenRegionTime 89.585
-InsertPHITime 0.425
-SSARenameTime 0.027
-TotalMSSATime 91.283
+GenMUCHITime 1.256
+GenRegionTime 90.803
+InsertPHITime 0.422
+SSARenameTime 0.032
+TotalMSSATime 92.515
----------------Numbers stats----------------------------
BBHasMSSAPhi 4056
CSChiNode 22213
@@ -247,13 +247,13 @@
SVFG Statistics******
################ (program : nginx.bc)###############
----------------Time and memory stats--------------------
-ATNodeTime 0.219
+ATNodeTime 0.226
AvgWeight 198.378
ConnDirEdgeTime 0
-ConnIndEdgeTime 1.346
+ConnIndEdgeTime 1.334
OptTime 0
TLNodeTime 0
-TotalTime 1.565
+TotalTime 1.56
----------------Numbers stats----------------------------
ActualIn 30142
ActualOut 22213
@@ -315,20 +315,20 @@
GepTime 0
IndirectPropaTime 0
LoadTime 0
-MemoryUsageVmrss 4.86294e+06
-MemoryUsageVmsize 4.91137e+06
+MemoryUsageVmrss 4.86157e+06
+MemoryUsageVmsize 4.91083e+06
PhiTime 0
-PrelabelingTime 0.171
+PrelabelingTime 0.164
ProcessTime 0
PropagationTime 0
SCCTime 0
-SolveTime 822.046
+SolveTime 844.559
StoreTime 0
Strong/WeakUpdTime 0
-TotalTime 893.043
+TotalTime 905.531
UpdateCGTime 0
VersionPropTime 0
-meldLabelingTime 68.252
+meldLabelingTime 68.278
----------------Numbers stats----------------------------
CopysNum 80
DummyFieldPtrs 1510
@@ -348,11 +348,11 @@
ProcessedAddr 23636
ProcessedCopy 320
ProcessedFRet 0
-ProcessedGep 889573
-ProcessedLoad 1176923
+ProcessedGep 888672
+ProcessedLoad 1168142
ProcessedMSSANode 344692
-ProcessedPhi 76612
-ProcessedStore 636942
+ProcessedPhi 75732
+ProcessedStore 632325
SolveIterations 4
StoresNum 14929
StrongUpdates 282
@@ -367,12 +367,12 @@

Persistent Points-To Cache Statistics: flow-sensitive analysis bitvector
################ (program : nginx.bc)###############
-UniquePointsToSets 35730
-TotalUnions 1955430568
-PropertyUnions 1226375795
-UniqueUnions 132984
-LookupUnions 728751752
-PreemptiveUnions 170037
+UniquePointsToSets 35751
+TotalUnions 1937211190
+PropertyUnions 1193594500
+UniqueUnions 132775
+LookupUnions 743314054
+PreemptiveUnions 169861
TotalComplements 0
PropertyComplements 0
UniqueComplements 0

@yuleisui yuleisui merged commit e63973d into SVF-tools:master Jan 27, 2025
5 checks passed
@jumormt jumormt deleted the 1.27 branch January 29, 2025 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0