-
Notifications
You must be signed in to change notification settings - Fork 458
remove some svfvalue in svfcore #1641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -500,11 +497,6 @@ class CondPTAImpl : public PointerAnalysis | |||
return objToNSRevPtsMap[obj]; | |||
} | |||
|
|||
/// Interface expose to users of our pointer analysis, given Value infos | |||
virtual inline AliasResult alias(const SVFValue* V1, const SVFValue* V2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to keep SVFVar* V1 and SVFVar* V2 api.
@@ -232,10 +232,6 @@ class PointerAnalysis | |||
/// Compute points-to results on-demand, overridden by derived classes | |||
virtual void computeDDAPts(NodeID) {} | |||
|
|||
/// Interface exposed to users of our pointer analysis, given Value infos | |||
virtual AliasResult alias(const SVFValue* V1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace SVFValue with SVFVar
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1641 +/- ##
==========================================
+ Coverage 63.74% 63.82% +0.07%
==========================================
Files 247 247
Lines 26054 26014 -40
Branches 4511 4500 -11
==========================================
- Hits 16609 16604 -5
+ Misses 9445 9410 -35
|
* Determine whether a const CallICFGNode* instruction can mod or ref | ||
* a specific memory location pointed by V | ||
*/ | ||
ModRefInfo MRGenerator::getModRefInfo(const CallICFGNode* cs, const SVFValue* V) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SVFValue* => SVFVar* V
* Return alias results based on our points-to/alias analysis | ||
* TODO: Need to handle PartialAlias and MustAlias here. | ||
*/ | ||
AliasResult DDAPass::alias(const SVFValue* V1, const SVFValue* V2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SVFValue* => SVFVar* V
--- log/nginx.log 2025-01-27 15:55:45.574264574 +1100 PTACallGraph Stats (Andersen analysis)****** Memory SSA Statistics****** Persistent Points-To Cache Statistics: flow-sensitive analysis bitvector |
No description provided.