svfargument->argvalvar #1644
svfargument->argvalvar #1644
Conversation
svf-llvm/lib/SVFIRBuilder.cpp
Outdated
| @@ -230,6 +230,8 @@ void SVFIRBuilder::initialiseNodes() | |||
| iter->second, argval->getArgNo(), icfgNode, | |||
| llvmModuleSet()->getCallGraphNode(argval->getParent()),iter->first->getType(), | |||
| LLVMUtil::isArgOfUncalledFunction(argval)); | |||
| if (!argval->hasName()) | |||
| pag->getGNode(iter->second)->setName(std::to_string(argval->getArgNo())); | |||
There was a problem hiding this comment.
What is our previous way for setname of an argument?>
There was a problem hiding this comment.
Name and sourceloc are set in the same way as other vars:
SVF/svf-llvm/lib/LLVMModule.cpp
Line 1331 in 42570b4
There was a problem hiding this comment.
what is the difference between val->getName().str() and argval->getArgNo()? We shall use the former one?
There was a problem hiding this comment.
we use argval->getArgNo() only when the arg does not have name and val->getName().str() otherwise.
There was a problem hiding this comment.
It is consistent with prior design:
SVF/svf-llvm/lib/LLVMModule.cpp
Lines 294 to 295 in 42570b4
There was a problem hiding this comment.
what is the string value of the getName for a typical argval? Is that "arg no."? We need to align the format.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1644 +/- ##
=======================================
Coverage 63.83% 63.84%
=======================================
Files 246 246
Lines 25988 25995 +7
Branches 4505 4508 +3
=======================================
+ Hits 16589 16596 +7
Misses 9399 9399
|
|
--- log/nginx.log 2025-01-31 15:14:28.567766333 +1100 PTACallGraph Stats (Andersen analysis)****** @@ -220,11 +220,11 @@ Persistent Points-To Cache Statistics: flow-sensitive analysis bitvector |
No description provided.