-
Notifications
You must be signed in to change notification settings - Fork 458
step1: remove preAbstrace and use use a temporary state to collect st… #1523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1523 +/- ##
==========================================
- Coverage 65.42% 65.42% -0.01%
==========================================
Files 256 256
Lines 26921 26920 -1
Branches 4810 4807 -3
==========================================
- Hits 17614 17612 -2
- Misses 9307 9308 +1
|
| @@ -181,18 +180,30 @@ void AbstractInterpretation::handleGlobalNode() | |||
| /// get execution state by merging states of predecessor blocks | |||
| /// Scenario 1: preblock -----(intraEdge)----> block, join the preES of inEdges | |||
| /// Scenario 2: preblock -----(callEdge)----> block | |||
| bool AbstractInterpretation::mergeStatesFromPredecessors(const ICFGNode *block) | |||
| bool AbstractInterpretation::mergeStatesFromPredecessors(const ICFGWTOComp * wtoCmp) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AbstractInterpretation::mergeStatesFromPredecessors(const ICFGWTOComp * wtoCmp) =>
AbstractInterpretation::mergeStatesFromPredecessors(const ICFGNode * icfgNode)
| } | ||
| // Handle WTO cycles | ||
| else if (const ICFGCycleWTO* cycle = SVFUtil::dyn_cast<ICFGCycleWTO>(wtoNode)) | ||
| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if(mergeStatesFromPredecessors(cycle->head()->node()))
handleCycleWTO(node);
| return; | ||
| } | ||
| if (const ICFGSingletonWTO* node = SVFUtil::dyn_cast<ICFGSingletonWTO>(wtoNode)) | ||
| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if(mergeStatesFromPredecessors(wtonode->getNode()))
handleSingletonWTO(node);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also rename the following:
ICFGSingletonWTO::getNode=> ICFGSingletonWTO::getICFGNode();
ICFGCycleWTO::getNode=> ICFGCycleWTO::getICFGNode();
…ates from predecessors