Improve exporting process for AHOY with OBB models #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re proper handling of weights path as a string.
…onsistency in error handling and status messages.
…e better results. A few simplifcations added as well.
…g AHOYv1 and AHOYv2 classes for better model management. Update export functions to accommodate these changes and enhance model export preparation.
…ormat and clipping. Adjust padding calculations for bounding boxes based on the new parameters.
…padding alongside the transformation. Update scaling logic in AHOYv1 and AHOYv2 classes to utilize the new ratio padding for accurate bounding box adjustments after transformations. Change interpolation method from NEAREST to BILINEAR for improved image quality.
… streamline model export process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Refactored the model export process to ensure the ONNX graph retains all simplifications implemented in the original ultralytics repository.
Also, new naming convention:
-
AHOY-->AHOYv1-
AHOYOBB-->AHOYv2Tip
You can still use
AHOY(obj_det_weigths="", hor_det_weigths="", ...); the correct version will be selected automatically based on the provided weights 🤞Why?
Addressed these key issues in the export pipeline:
Note
There is nothing wrong with
AHOYOBB, but… what if in the future we do both object and horizon detection with OBB models? Would we call itAHOYOBBOBBorAHOYOBB²?A more conventional naming scheme (a.k.a.
AHOYv*) could help keep architectural insights and naming separate. You don’t see names likeYOLOAnchorlessorYOLOFlashAttention, those details are captured in documentation or model cards, not embedded in the name. Following that spirit keeps names clean and evolution-friendly.How
loggingtoLOGGERfor unified loggingprepare_for_export()to centralize export logic in model classesAHOYbase class and subclasses forAHOYv1andAHOYv2.Backout plan
The changes improve the exporting, they should not be reverted.
Testing
W&B integration
Before
After