8000 Please update podspec · Issue #568 · SDWebImage/SDWebImage · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Please update podspec #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshuaGross opened this issue Dec 2, 2013 · 11 comments
Closed

Please update podspec #568

JoshuaGross opened this issue Dec 2, 2013 · 11 comments

Comments

@JoshuaGross
Copy link

Hi! Could you update the 3.5 tag, and/or tag a new version (3.5.1 ?) and update the CocoaPod podspec? A few of my projects need the recent changes but the latest podspec, 3.5, points to the tag from 2 months ago. For now I'll just point to the repository directly but it'd be nice to get CocoaPods updated too.

https://github.com/CocoaPods/Specs/tree/master/SDWebImage

Thanks!
@rs rs closed this as completed in 6878fba Dec 3, 2013
@JoshuaGross
Copy link
Author

Could you please also update the CocoaPods podspec?

@rs
Copy link
Member
rs commented Dec 3, 2013

Already done

@JoshuaGross
Copy link
Author

I must be missing something. 3.5 is the latest here: https://github.com/CocoaPods/Specs/tree/master/SDWebImage
And I don't see any relevant pull requests. What should I be looking at?

@rs
Copy link
Member
rs commented Dec 3, 2013

I guess there's a cronjob somewhere, I never had to push anything on cocoapods.

@JoshuaGross
Copy link
Author

Can you run pod push master? We're still stuck on 3.5 in the podspec.

http://guides.cocoapods.org/making/making-a-cocoapod.html#release

@JoshuaGross
Copy link
Author
JoshuaGross 8000 commented Dec 5, 2013

And/or this. http://guides.cocoapods.org/making/specs-and-specs-repo.html

It looks like someone else has been doing this for you for previous releases?

@bensie
Copy link
bensie commented Dec 5, 2013

@JoshuaGross CocoaPods supports git targets, so you can point directly at rs/SDWebImage rather than relying on an official podspec in CocoaPods/Specs. In the case that the podspec defined in rs/SDWebImage is outdated or not quite what you need, you can go further and write your own and put it in a Gist, pointing Cocoapods at the raw version of the gist. Great for forks or if you want to bind to a particular commit.

@JoshuaGross
Copy link
Author

@bensie I realize this, and I'm currently using a repo target with the 3.5.1 tag. I also think it's problematic that the official podspec is outdated.

@bensie
Copy link
bensie commented Dec 5, 2013

@JoshuaGross Nothing is stopping you from opening a PR on CocoaPods/Specs with the updated spec.

@JoshuaGross
Copy link
8000 Author

Agreed, however, I would also like to discuss this with @rs as he is the maintainer. If he thinks the podspec will update automatically, it appears that is incorrect, and he should know that. If his response is "you do it" I will respectfully comply for now, but this is not my project and I will not be updating the podspec for future versions (one of my PRs is included in 3.5.1, which is why I care more about it and was even aware that the podspec was outdated).
I could just go solve this problem for Olivier but the underlying issue would still be there, which is why I'm waiting for his response.

@rs
Copy link
Member
rs commented Dec 5, 2013

I'm not a cocoapod user, that's why I don't really carefully update it. Would be nice if it could be handled automatically using a hook.

phamquy pushed a commit to phamquy/SDWebImage that referenced this issue Dec 9, 2013
Merge branch 'master' of https://github.com/rs/SDWebImage
ccc24b5 
# By Olivier Poitrey (16) and others
# Via Olivier Poitrey (21) and others
* 'master' of https://github.com/rs/SDWebImage: (47 commits)
  Code cleanup.
  Added a delegate for the web image prefetched.
  Bump version to 3.5.1 (fix SDWebImage#568)
  matched coding conventions
  added currentDownload Count, to allow someone to see how many operations are left.
  Add HTTP header filter to pick headers for downloading request
  up version 3.5 in podspec to be consistent with latest
  NSInteger -> NSUInteger, add getter method
  Allow setting a custom memory cost limit for the in-memory NSCache. This can help to keep memory down before memory warnings are sent by the device.
  Added SDWebImageOption to enable Cookies Handling.
  Only perform `NSLog` statements if `SD_VERBOSE` is defined
  Use UIImagePNGRepresentation to preserve transparency
  Update argument list for example in README
  Fix link to "Who Uses SDWebImage" wiki page
  Provide background option through the manager
  Add option to continue download in background
  Fix WebP target
  Removed strong reference to UIImageView which was causing a crash in the nested block.
  Remove WebP support from default target and add a dedicated target
  Only use the runloop with timeout on iOS 5 (fix SDWebImage#497)
  ...

Conflicts:
	SDWebImage.xcodeproj/project.pbxproj
devedup pushed a commit to FilmFlexMovies/SDWebImage that referenced this issue Sep 10, 2014
@devedup
Bump version to 3.5.1 (fix SDWebImage#568)
7500f0a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bensie @rs @JoshuaGross
0