More align SA1 and SA2 #203
Conversation
| PAUSE_GRAPHICS_QUEUE(); | ||
|
|
||
| #if (GAME == GAME_SA1) | ||
| if (!dm->playerPressedStart) { | ||
| CreateSegaLogo(); |
There was a problem hiding this comment.
We could possibly align these by calling them CreateTitleScreenIntro?
There was a problem hiding this comment.
The title screen logo is something different.
The "Sonic Advance" banner is created separately from the background, if I'm not mistaken.
As it is, it's clear what we mean.
| @@ -612,7 +617,7 @@ void SpawnMapEntities() | |||
| void Task_8008DCC(void) | |||
| { | |||
| #ifndef NON_MATCHING | |||
| struct Range *newRange2Ptr; | |||
| struct Range *newrange2Ptr; | |||
There was a problem hiding this comment.
Why is this relabelled?
There was a problem hiding this comment.
Maybe a search and replace error
| character = &p->character; | ||
| memset(p->unk99, 0, sizeof(p->unk99)); | ||
| { | ||
| u32 *ptr = (u32 *)(&p->SA2_LABEL(unk99)[0]); |
There was a problem hiding this comment.
You can probably remove the comment above with regard to the "actual" code
| ring->unkC--; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| #define USE_HITBOX_RECT 1 |
There was a problem hiding this comment.
Do these need to be added back?
There was a problem hiding this comment.
Well, they're still used. But of course I don't want to insert something that's not needed. ^^
src/game/stage/player.c
Outdated
| playerID = &p->playerID; | ||
| character = &p->character; | ||
| u32 *ptr = (u32 *)(&p->SA2_LABEL(unk99)[0]); | ||
|
|
||
| s32 i = 4; |
There was a problem hiding this comment.
This still isn't gonna work lol
src/game/stage/player.c
Outdated
| @@ -794,9 +794,9 @@ void InitializePlayer(Player *p) | |||
| *u99_r6 = 0x7F; | |||
| #else | |||
| { | |||
| u32 *ptr = (u32 *)(&p->SA2_LABEL(unk99)[0]); | |||
| playerID = &p->playerID; | |||
There was a problem hiding this comment.
Also, if you really think this loop is real code, you might as well just wrap the if ((*playerID == 0) in non matches too and not use the pointers if you are not using the asm. The code you have here is like half way between a fake a real match.
| #endif | ||
|
|
||
| #if (GAME == GAME_SA1) | ||
| p->acceleration = Q(8. / 256.); |
There was a problem hiding this comment.
? Acceleration is the same?
No description provided.