fix: add punchout error page #20366
Draft
fix: add punchout error page #20366
+43
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pucek9
reviewed
May 22, 2025
| <div class="alert"> | ||
| <span class="alert-icon"> | ||
| <cx-icon | ||
| class="cx-icon fas fa-exclamation-circle" |
There was a problem hiding this comment.
Suggested change
| class="cx-icon fas fa-exclamation-circle" | |
| [type]="ICON_TYPE.ERROR" |
Pucek9
reviewed
May 22, 2025
Comment on lines
8
to
14
|
|
||
| @Component({ | ||
| selector: 'cx-punchout-error', | ||
| template: `<h2>Punchout Error</h2> | ||
| <p>Please navigate back to Ariba</p> `, | ||
| templateUrl: './punchout-error.component.html', | ||
| standalone: false, | ||
| }) | ||
| export class PunchoutErrorComponent {} |
There was a problem hiding this comment.
Suggested change
| @Component({ | |
| selector: 'cx-punchout-error', | |
| template: `<h2>Punchout Error</h2> | |
| <p>Please navigate back to Ariba</p> `, | |
| templateUrl: './punchout-error.component.html', | |
| standalone: false, | |
| }) | |
| export class PunchoutErrorComponent {} | |
| export class PunchoutErrorComponent { | |
| ICON_TYPE = ICON_TYPE; | |
| } |
Pucek9
reviewed
May 22, 2025
| @@ -8,8 +8,7 @@ import { Component } from '@angular/core'; | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
| import { ICON_TYPE } from '@spartacus/storefront'; | |
|
Are we able to add pages like this as CMS-paragraph (I mean mainly the icon)? If yes, it's worth considering making it with sampledata only |
spartacus
|
||||||||||||||||||||||||||||
| Project |
spartacus
|
| Branch Review |
fix/CXSPA-10229
|
| Run status |
|
| Run duration | 05m 10s |
| Commit |
|
| Committer | Florent Letendre |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
236
|
| View all changes introduced in this branch ↗︎ | |
FollowTheFlo
commented
May 23, 2025
| @@ -9,40 +9,41 @@ import { NgModule } from '@angular/core'; | |||
| import { ReactiveFormsModule } from '@angular/forms'; | |||
| import { CartSharedModule } from '@spartacus/cart/base/components'; | |||
| import { CmsConfig, I18nModule, provideDefaultConfig } from '@spartacus/core'; | |||
| import { IconModule } from '@spartacus/storefront'; | |||
There was a problem hidi 8000 ng this comment.
still needed as punchout error paragrap cpnt contains cx-icon
17a74db to
7a25d94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.