8000 Feature/gh 11825 quick order form by dydome · Pull Request #11945 · SAP/spartacus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feature/gh 11825 quick order form #11945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 13, 2021
Merged

Feature/gh 11825 quick order form #11945

merged 4 commits into from
Apr 13, 2021

Conversation

dydome
Copy link
Contributor
@dydome dydome commented Apr 13, 2021

close #11825

@dydome dydome temporarily deployed to dev April 13, 2021 07:29 Inactive
@dydome dydome self-assigned this Apr 13, 2021
@cypress
Copy link
cypress bot commented Apr 13, 2021 •
edited
Loading


Test summary

472 • 0 • 9 • 0 • Flakiness 4

Run details
Project spartacus
Status Passed
Commit 62e6246 ℹ️
Started Apr 13, 2021 8:24 AM
Ended Apr 13, 2021 8:33 AM
Duration 08:53 💡
OS Linux Ubuntu - 18.04
Browser Electron 87

View run in Cypress Dashboard ➡️

Flakiness

cart.e2e-spec.ts 2 Flakiness
1 ... > should add and remove products
2 ... > should add and remove products
login.e2e-spec.ts 2 Flakiness
1 Login > Mobile > login should fail if password is wrong
2 Login > Desktop > login should fail if password is wrong

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

psmul
psmul suggested changes Apr 13, 2021
View reviewed changes
@dydome dydome requested a review from psmul April 13, 2021 08:14
@dydome dydome temporarily deployed to dev April 13, 2021 08:14 Inactive
@dydome dydome merged commit 39b2089 into epic/quick-order Apr 13, 2021
@dydome dydome deleted the feature/GH-11825-quick-order-form branch April 13, 2021 08:38
@dydome dydome temporarily deployed to dev April 13, 2021 08:38 Inactive
@github-actions
Copy link
Contributor

Public API changes

⚠️ @spartacus/cart/quick-order/components

 // @public (undocumented)
 export class QuickOrderComponent {
+    // (undocumented)
+    addToCart(): void;
+    // (undocumented)
+    clear(): void;
 }
 
 // @public (undocumented)

⚠️ Some entry points are currently impossible to analyze.

Read more
  • @spartacus/asm/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/cart/saved-cart/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/cdc - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/organization/administration/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/organization/order-approval - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/product-configurator/rulebased - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/storefinder/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/storefront - ERROR: The expression contains an import() type, which is not yet supported by API Extractor:

💰 How to debug problems?

Read more

Problem with import() type

It happens when type is deduced by TS based on code and at the same time the deduced type is not present in the file.
In this specific case to support api-extractor it's worth to add type declaration explicitly.

Debugging steps:

  • go to the bot action logs
  • find api-extractor logs for broken library
  • check in which file and line the problems exists
  • build the library locally and check content of the file mentioned in logs (look for import()
  • add explicit type to problematic source code
  • build the library once again and verify that the import( is no longer present
  • commit and push the code with defined type

Problem with import * as ___

Api-extractor doesn't support this namespace syntax.
Check if you really need to use namespace in the library. Try to avoid namespaces when possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psmul psmul psmul approved these changes

Assignees

@dydome dydome

Labels
quick-order
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dydome @psmul
0