8000 Create new component for "EXIT CONFIGURATION" Button in SPA Header · Issue #13806 · SAP/spartacus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Create new component for "EXIT CONFIGURATION" Button in SPA Header # 8000 13806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Larisa-Staroverova opened this issue Sep 21, 2021 · 1 comment · Fixed by #14043 or #14213
Closed

Create new component for "EXIT CONFIGURATION" Button in SPA Header #13806

Larisa-Staroverova opened this issue Sep 21, 2021 · 1 comment · Fixed by #14043 or #14213
Assignees
@ChristophHi
Labels
vc/ui-round-off
Milestone
vc

Comments

@Larisa-Staroverova
Copy link
Contributor
Larisa-Staroverova commented Sep 21, 2021 •
edited by schuppell
Loading

New component should trigger a "browser back" when clicked.
When no browser back is possible, the user should go the the product detail of the product which is configured.

Component will be added in rulebased module, lazy loading is expected.
Component has to take care that the header is styled correctly.
@Changsuwan Changsuwan self-assigned this Sep 29, 2021
@steinsebastian steinsebastian added this to the vc milestone Oct 1, 2021
Changsuwan added a commit that referenced this issue Oct 4, 2021
@Changsuwan
GH-13806: Add new component for configurator exit button
ae49478
ChristophHi added a commit that referenced this issue Oct 4, 2021
@ChristophHi
Merge branch 'feature/GH-13807-layout-changes' into feature/GH-13806-…
2b2db53 
…exit-button
ChristophHi added a commit that referenced this issue Oct 4, 2021
@ChristophHi
GH-13806 Add new component to feature configuration
61497a2
ChristophHi added a commit that referenced this issue Oct 4, 2021
@ChristophHi
GH-13806 fix comment
9f98d72
ChristophHi added a commit that referenced this issue Oct 5, 2021
@ChristophHi
GH-13806 review feedback
2686a8c
Changsuwan added a commit that referenced this issue Oct 12, 2021
@Changsuwan
GH-13806: add button (logic and styling)
af7c81a
Changsuwan added a commit that referenced this issue Oct 12, 2021
@Changsuwan
Merge branch 'feature/GH-13806-exit-button' of https://github.com/SAP…
346cb2d 
…/spartacus into feature/GH-13806-exit-button
Changsuwan added a commit that referenced this issue Oct 12, 2021
@Changsuwan
GH-13806: add styling for right position
afb17b1
Changsuwan added a commit that referenced this issue Oct 13, 2021
@Changsuwan
GH-13806: add test for exit button component
08970e1
schuppell pushed a commit that referenced this issue Oct 13, 2021
@schuppel
GH-13806: add unit tests
95e0242
schuppell pushed a commit that referenced this issue Oct 13, 2021
@schuppel
GH-13806: Fix mobile text
baf0a87
Changsuwan added a commit that referenced this issue Oct 14, 2021
@Changsuwan
GH-13806: fix button to show text once and styling
fe0500c
Changsuwan added a commit that referenced this issue Oct 14, 2021
@Changsuwan
GH-13806: Test for exit button
b9b4c81
Changsuwan added a commit that referenced this issue Oct 15, 2021
@Changsuwan
GH-13806: Add exit button to overview
38c377c
Changsuwan added a commit that referenced this issue Oct 15, 2021
@Changsuwan
GH-13806: Add exit button to overview page
bdd23df
Changsuwan added a commit that referenced this issue Oct 15, 2021
@Changsuwan
Merge branch 'develop' into feature/GH-13806-exit-button
69d6d69
@Changsuwan Changsuwan linked a pull request Oct 15, 2021 that will close this issue
Feature/gh 13806 exit button #14043
Merged
@Changsuwan Changsuwan removed their assignment Oct 15, 2021
@Larisa-Staroverova Larisa-Staroverova self-assigned this Oct 15, 2021
Changsuwan added a commit that referenced this issue Oct 15, 2021
@Changsuwan
GH-13806: fix unit tests
6ee382a
Changsuwan added a commit that referenced this issue Oct 15, 2021
@Changsuwan
Merge branch 'feature/GH-13806-exit-button' of https://github.com/SAP…
868bfd5 
…/spartacus into feature/GH-13806-exit-button
Larisa-Staroverova added a commit that referenced this issue Oct 18, 2021
@Larisa-Staroverova
Merge branch 'develop' into feature/GH-13806-exit-button
5b56cf6
Changsuwan added a commit that referenced this issue Oct 18, 2021
@Changsuwan
GH-13806: adjust button behavior and fix tests
5798ee4
Changsuwan added a commit that referenced this issue Oct 18, 2021
@Changsuwan
Merge branch 'feature/GH-13806-exit-button' of https://github.com/SAP…
846ae00 
…/spartacus into feature/GH-13806-exit-button
Changsuwan added a commit that referenced this issue Oct 18, 2021
@Changsuwan
Merge branch 'develop' into feature/GH-13806-exit-button
084c36a
Larisa-Staroverova added a commit that referenced this issue Oct 19, 2021
@Larisa-Staroverova
Merge branch 'develop' into feature/GH-13806-exit-button
5cdd0f3
Changsuwan added a commit that referenced this issue Oct 19, 2021
@Changsuwan
GH-13806: fix method name and comments
565d9b7
Changsuwan added a commit that referenced this issue Oct 19, 2021
@Changsuwan
Merge branch 'feature/GH-13806-exit-button' of https://github.com/SAP…
2b71c54 
…/spartacus into feature/GH-13806-exit-button
Changsuwan added a commit that referenced this issue Oct 19, 2021
@Changsuwan
Merge branch 'develop' into feature/GH-13806-exit-button
c2ca809
Larisa-Staroverova added a commit that referenced this issue Oct 19, 2021
@Larisa-Staroverova
Merge branch 'develop' into feature/GH-13806-exit-button
8bba85b
Larisa-Staroverova added a commit that referenced this issue Oct 20, 2021
@Larisa-Staroverova
Merge branch 'develop' into feature/GH-13806-exit-button
312590e
Larisa-Staroverova pushed a commit that referenced this issue Oct 20, 2021
@Changsuwan
feat: Add exit button (#14043)
0932e90 
Create a new component for 'EXIT CONFIGURATION' button to enable an opportunity to leave the configuration any time by navigation to a product detail page

Closes #13806
Changsuwan added a commit that referenced this issue Nov 3, 2021
@Changsuwan
GH-13806: add exit button to configurator in powertools
e7e556e
Changsuwan added a commit that referenced this issue Nov 3, 2021
@Changsuwan
GH-13806: change slot name
0fc7136
Changsuwan added a commit that referenced this issue Nov 4, 2021
@Changsuwan
Merge branch 'develop' into feature/GH-13806-add-exit-button-powertools
0b33af6
@ChristophHi
Copy link
Contributor

This is still open, since #14213 is pending. The corresponding sample data PR is also still open, no complete test possible

@ChristophHi ChristophHi reopened this Nov 4, 2021
Changsuwan added a commit that referenced this issue Nov 4, 2021
@Changsuwan
Merge branch 'develop' into feature/GH-13806-add-exit-button-powertools
6f44eaa
@ChristophHi ChristophHi mentioned this issue Nov 4, 2021
Merged
Changsuwan added a commit that referenced this issue Nov 8, 2021
@Changsuwan
GH-13806: adjust the styling for cpq exit button
591d958
Changsuwan added a commit that referenced this issue Nov 8, 2021
@Changsuwan
Merge branch 'feature/GH-13806-add-exit-button-powertools' of https:/…
ba3da81 
…/github.com/SAP/spartacus into feature/GH-13806-add-exit-button-powertools
ChristophHi added a commit that referenced this issue Nov 9, 2021
@ChristophHi
Merge branch 'develop' into feature/GH-13806-add-exit-button-powertools
bd69939
Changsuwan added a commit that referenced this issue Nov 9, 2021
@Changsuwan
Merge branch 'develop' into feature/GH-13806-add-exit-button-powertools
2b82d23
Changsuwan added a commit that referenced this issue Nov 9, 2021
@Changsuwan
feature: add exit button to cpq configurator (#14213)
320b099 
User will have the possibility to exit the configurator and go back to the product detail page by clicking the exit button this branch provides.

BREAKING CHANGE:
header has a new element (the changes are only visible in the product configurator).

Closes #13806
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChristophHi ChristophHi

Labels
vc/ui-round-off
Projects
None yet
Milestone
vc
5 participants
@ChristophHi @schuppell @steinsebastian @Larisa-Staroverova @Changsuwan
0