8000 Complete the unit test for saved cart details page and core related · Issue #11327 · SAP/spartacus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Complete the unit test for saved cart details page and core related #11327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
9 tasks done
bgambocjaviniar opened this issue Mar 2, 2021 · 1 comment
Closed
9 tasks done

Complete the unit test for saved cart details page and core related #11327

bgambocjaviniar opened this issue Mar 2, 2021 · 1 comment
Assignees
@bgambocjaviniar
Labels
saved-carts team/obelix
Milestone
3.x

Comments

@bgambocjaviniar
Copy link
Contributor
bgambocjaviniar commented Mar 2, 2021 •
edited
Loading

related to this PR #11326 after the PR gets merged

  • feature-libs/cart/saved-cart/core/connectors/saved-cart.connector.ts
  • feature-libs/cart/saved-cart/core/services/saved-cart.service.ts
  • feature-libs/cart/saved-cart/core/store/actions/saved-cart.action.ts
  • feature-libs/cart/saved-cart/core/store/effects/saved-cart.effect.ts
  • feature-libs/cart/saved-cart/occ/adapters/occ-saved-cart.adapter.ts
  • feature-libs/cart/saved-cart/components/details/saved-cart-detail-action/saved-cart-detail-action.component.ts
  • feature-libs/cart/saved-cart/components/details/saved-cart-detail-items/saved-cart-detail-items.component.ts
  • feature-libs/cart/saved-cart/components/details/saved-cart-detail-overview/saved-cart-detail-overview.component.ts
  • feature-libs/cart/saved-cart/components/details/saved-cart-detail.service.ts

can be done together with #11325 to avoid conflicts

feature-libs/cart/saved-cart//core
feature-libs/cart/saved-cart//occ

were done in this PR #11409

feature-libs/cart/saved-cart/components/details/saved-cart-detail-items/saved-cart-detail-items.component.ts won't be part of this as it's going to be part of GH-9199
@bgambocjaviniar bgambocjaviniar added this to the 3.x milestone Mar 2, 2021
This was referenced Mar 2, 2021
Closed
Closed
Merged
@bgambocjaviniar bgambocjaviniar self-assigned this Mar 8, 2021
bgambocjaviniar added a commit that referenced this issue Mar 9, 2021
@bgambocjaviniar
Merge branch 'feature/GH-11327' of github.com:SAP/spartacus into feat…
542d582 
…ure/GH-11327
bgambocjaviniar added a commit that referenced this issue Mar 9, 2021
@bgambocjaviniar
Merge branch 'epic/saved-carts' into feature/GH-11327
ea2a881
@bgambocjaviniar bgambocjaviniar mentioned this issue Mar 9, 2021
Merged
@bgambocjaviniar
Copy link
Contributor Author

PR: GH-11443

bgambocjaviniar added a commit that referenced this issue Mar 10, 2021
@bgambocjaviniar
Merge branch 'epic/saved-carts' into feature/GH-11327
2923f15
bgambocjaviniar added a commit that referenced this issue Mar 10, 2021
@bgambocjaviniar
Merge branch 'epic/saved-carts' into feature/GH-11327
64bb737
bgambocjaviniar added a commit that referenced this issue Mar 10, 2021
@bgambocjaviniar
Unit tests for details page + exposing components/services + change t…
4eeb8f4 
…o eslint (GH-11327)

* Unit tests for details page + exposing components/services

* restore save cart change in order to use default name value when empty string is passed

* fix directionality issue with border-right

* removed unused styling

* update to eslint

* prettier + version update to libs

* removed a 'it' duplication unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bgambocjaviniar bgambocjaviniar

Labels
saved-carts team/obelix
Projects
None yet
Milestone
3.x
Development

No branches or pull requests
1 participant
@bgambocjaviniar
0