8000 Hide edit context button on non-owned messages by DanielleMaywood · Pull Request #101 · SwiftcordApp/Swiftcord · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Hide edit context button on non-owned messages #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2022
Merged

Hide edit context button on non-owned messages #101

merged 1 commit into from
Aug 19, 2022

Conversation

DanielleMaywood
Copy link
Contributor

Hides the "Edit" button in the context menu for messages sent by anyone other than the current user.

@DanielleMaywood DanielleMaywood changed the title Hide edit cotext button on non-owned messages Hide edit context button on non-owned messages Aug 18, 2022
@cryptoAlgorithm
Copy link
Member

Thanks for your contribution. The commits look good, but have you done performance testing? I'm worried the extra environment object has a significant CPU/memory impact, especially for longer chats.

@DanielleMaywood
Copy link
Contributor Author

Thanks for your contribution. The commits look good, but have you done performance testing? I'm worried the extra environment object has a significant CPU/memory impact, especially for longer chats.

I haven't but I can do some later today and post the results.

@cryptoAlgorithm
Copy link
Member

Thanks. Check the scrolling performance especially for longer channels.

@DanielleMaywood
Copy link
Contributor Author

The following are from me testing on my M1 Macbook Air on MacoS Ventura.

Performance profile from before changes:
SCR-20220819-i6p

Performanc profile from after changes:
SCR-20220819-i6w

Anecdotally, the smoothness of scrolling through channels with lots of messages feels the same to me.

@cryptoAlgorithm
Copy link
Member

Lmao, it looks like performance actually improved xD. Ok, I'm merging this PR.

@cryptoAlgorithm cryptoAlgorithm merged commit 8a44940 into SwiftcordApp:main Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielleMaywood @cryptoAlgorithm
0