Updated EntryPoint to allow for linux compilations #47
Conversation
The project works and compiles with my CMake fork [here](https://github.com/AbduEhab/Walnut-CMake-Template). I can provide a screenshot of it compiling on Debian KDE if required.
|
@coderabbitai review |
WalkthroughThe recent update focuses on enhancing code readability and consistency across the project. It primarily addresses the formatting of function parameters and the structure of namespace blocks, ensuring uniformity and clearer code structure. This refinement aims at improving the development experience by making the codebase easier to navigate and understand. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (1)
- Walnut/src/Walnut/EntryPoint.h (3 hunks)
Additional comments not posted (4)
Walnut/src/Walnut/EntryPoint.h (4)
3-3: The declaration ofWalnut::CreateApplicationand the global variableg_ApplicationRunningare correctly placed and formatted.
6-13: The adjustments to theMainfunction's parameter spacing and the reformatting of the namespace block enhance code readability and consistency.
20-27: > 📝 NOTEThis review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [23-36]
The conditional compilation and structure of the
mainfunction for the Windows platform are correctly implemented and formatted.
42-48: The definition of themainfunction for non-Windows platforms is a key change for enabling Linux compilations, correctly implemented and formatted.
|
Are there any plans to merge this? |
|
Stumbled on to this while attempting to create Walnut as a Meson build project instead of a CMAKE project. If @TheCherno ever decides to provide support for other build systems such as Meson, I'm more than happy to send in a PR. Either way, I think merging this PR at least should be a no brainer. |
The project works and compiles with my CMake version of the project which can be found here. It compiles on Ubuntu KDE. The changes should allow for macOS compilations too but I haven't tested them.
Summary by CodeRabbit