8000 Remove `composer.lock` by kenvunz · Pull Request #68 · StoutLogic/acf-builder · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove composer.lock #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2018
Merged

Remove composer.lock #68

merged 1 commit into from
Aug 12, 2018

Conversation

kenvunz
Copy link
Contributor
@kenvunz kenvunz commented Aug 12, 2018

Leaving composer.lock in the package causing composer installation issue due to doctrine/inflector being locked at 1.1.0 in acf-builder's composer.lock file, and my project already has doctine/inflector being locked at 1.3.0, here is the details of the error:

  Problem 1
    - Installation request for doctrine/inflector (locked at v1.3.0) -> satisfiable by doctrine/inflector[v1.3.0].
    - stoutlogic/acf-builder dev-master requires doctrine/inflector ~1.1.0 -> satisfiable by doctrine/inflector[v1.1.0].
    - stoutlogic/acf-builder dev-master requires doctrine/inflector ~1.1.0 -> satisfiable by doctrine/inflector[v1.1.0].
    - Conclusion: don't install doctrine/inflector v1.1.0
    - Installation request for stoutlogic/acf-builder dev-master -> satisfiable by stoutlogic/acf-builder[dev-master].

@stevep stevep merged commit cce83a8 into StoutLogic:master Aug 12, 2018
@stevep
Copy link
Member
stevep commented Aug 12, 2018

@kenvunz good call, thanks

@Log1x
Copy link
Collaborator
Log1x commented Aug 12, 2018

I feel like the better solution to this would be to bump acf-builder's dependencies as they haven't been for a couple months.

Usually it's better practice to keep composer.lock VC'd [1].

@stevep
Copy link
Member
stevep commented Aug 12, 2018

@Log1x I would agree with you to commit composer.lock if this were a project, but as a library, I'm hesitant to do so. doctrine/inflector 1.3 has a php 7.1 minimum requirement but I still want to support 5.6 with ACF Builder. I original made the change in the composer.json file here 66b7ac3

In fact @kenvunz can you confirm that removing the lock allows you to user 1.3.0? We may have to add support for multiple versions in ACF Builder's composer.json file

@kenvunz
Copy link
Contributor Author
kenvunz commented Aug 12, 2018

@stevep ah yip, removing composer.lock does the trick for me and the plugin works great with doctrine/inflector 1.3 too

@stevep stevep mentioned this pull request Dec 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kenvunz @stevep @Log1x @ken-gladeye
0