create asgs versioning scheme and add asgs version to run.properties #412 #1461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks great @wwlwpd , appreciate the nice documentation and the expansion of scope to include more descriptive and diagnostic information.
…h checks. Issue 412: Tracking ASGS version; this PR adds some new tools and commands that make this information easier to query at the commandline. Updated help section; added some health checks - trying to guess age of installation and if the git repo is "healthy" - i.e., not "moth eaten" in the face of some HPC work directory purges: - guess age - guess health Added start up ./asgsh options to turn off checks. Resolves #412.
…p health checks. Adding patch for v53 to ensure proper macros.inc for SWAN
|
it's not doing what I thought it should be doing, so I need to track down why |
|
@wwlwpd please let me know if there is anything I can/should do to help with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to test to make sure the
run.propertiesis written correctly, but version is set from theVERSIONfile now. @jasonfleming if you don't mind giving it an initial glance, I'd appreciate the feedback. I went out of scope to some degree, added some checks that would help us see how old the ASGS installation was and if the git repo was complete or seemed corrupted (usesgit fsck- file system check.)