feat (translation): add ability to ignore keys in translations #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stichoza
requested changes
Dec 16, 2023
There was a problem hiding this comment.
Thanks for your work! 🙌🏼 Couple of changes:
- For easier understanding, can you rename methods
extract->extractParameters,inject->injectParameters,getReplacements->getParameters. - Make above mentioned methods
protected. Also, no need of testing non-public methods. - Make this feature optional. Would be better to get rid of the method
setPatternand addpreserveParameters(?string $pattern = null)that will enable this feature and set custom pattern if specified.
|
I've gone ahead and responded to your feedback. I have it so it always runs through the key extraction but it's ignored if you don't set it explicitly as requested. Tests are expanded to show a couple examples of this and one for custom key matching (like if you wanna do {{key}} for example). You can also set this off of the static method or constructor too for ease of use... // like this...
$translator = new GoogleTranslate(pattern: '/:(\w+/');
// or this...
GoogleTranslate::trans(pattern: '/:(\w+/');
// or this
$translator->preserveParameters('/:(\w+/');If patterns like |
Stichoza
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Allows us to provide keys to translate without eating them up, for example,
Hello :namewas becomingBonjour :nom. Now this will stored asBonjour :namestill.How does this work?
We do a couple preg_replace commands to extract replacements, modify the string before sending to Google, and then swap back in our replacements. In a string such as
Hello :name are you :type_of_greeting?for example this replaces this string withHello ${0} are you ${1}?with the ${\d} values being ignored by Google, everything around it gets translated. When we receive this translated string back we then swap these values out for the matching keys that should be there so it changes fromBonjour ${0} are you ${1}toBonjour :name are you :type_of_greeting?where our system can then translate it as normal.Notes
Resolves #198
Also introduces ambiguous space characters being introduced by Google Translate (see screenshot).