8000 [Refactor] Unify the local cache engine used by data cache. by trueeyu · Pull Request #60110 · StarRocks/starrocks · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Refactor] Unify the local cache engine used by data cache. #60110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

[Refactor] Unify the local cache engine used by data cache. #60110

wants to merge 12 commits into from
+135 −137

Conversation

trueeyu
Copy link
Contributor
@trueeyu trueeyu commented Jun 20, 2025 •
edited
Loading

Why I'm doing:

image

Before the PR, the block cache used the StarCache engine, and the page cache used the LRUCache engine. After the PR, DataCache will only use one local cache engine—either StarCache or LRUCache—so that memory space can be unified managed.

What I'm doing:

  • Unify the cache engine used by data cache
  • If datacache_enable=false, page cache and block cache is all disabled
  • Set default value of config::datacache_mem_size to 20%
  • TODO: doc and mertrics will be modified in next pr.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.5
    • 3.4
    • 3.3

trueeyu added 6 commits June 20, 2025 09:38
@trueeyu
Unified datacache engine
cf51d6a 
Signed-off-by: trueeyu <lxhhust350@qq.com>
@trueeyu
fix
5cbcb37 
Signed-off-by: trueeyu <lxhhust350@qq.com>
@trueeyu
fix
6413681 
Signed-off-by: trueeyu <lxhhust350@qq.com>
@trueeyu
fix
f5b0543 
Signed-off-by: trueeyu <lxhhust350@qq.com>
@trueeyu
fix
be5d353 
Signed-off-by: trueeyu <lxhhust350@qq.com>
@trueeyu
fix
77120ac 
Signed-off-by: trueeyu <lxhhust350@qq.com>
@trueeyu trueeyu changed the title Cache f [Refactor] Unify the cache engine used by data cache. Jun 20, 2025
trueeyu added 2 commits June 20, 2025 10:47
@trueeyu
fix
d9493c6 
Signed-off-by: trueeyu <lxhhust350@qq.com>
@trueeyu
fix
5931c88 
Signed-off-by: trueeyu <lxhhust350@qq.com>
@trueeyu trueeyu changed the title [Refactor] Unify the cache engine used by data cache. [Refactor] Unify the local cache engine used by data cache. Jun 20, 2025
trueeyu added 4 commits June 20, 2025 12:05
@trueeyu
fix
c23270c 
Signed-off-by: trueeyu <lxhhust350@qq.com>
@trueeyu
fix
378cd04 
Signed-off-by: trueeyu <lxhhust350@qq.com>
@trueeyu
fix
ea9cb6f 
Signed-off-by: trueeyu <lxhhust350@qq.com>
@trueeyu
fix
ee7dbcc 
Signed-off-by: trueeyu <lxhhust350@qq.com>
@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

❌ fail : 0 / 3 (00.00%)

file detail

7369
path covered_line new_line coverage not_covered_line_detail
🔵 src/http/action/update_config_action.cpp 0 3 00.00%[93, 94, 103]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@trueeyu trueeyu

Labels
behavior_changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@trueeyu
0