8000 [BugFix] extend the DEFER LOCK optimization to SUBMIT TASK by murphyatwork · Pull Request #60026 · StarRocks/starrocks · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[BugFix] extend the DEFER LOCK optimization to SUBMIT TASK #60026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 20, 2025
Merged

[BugFix] extend the DEFER LOCK optimization to SUBMIT TASK #60026

merged 3 commits into from
Jun 20, 2025
+94 −7

Conversation

murphyatwork
Copy link
Contributor
@murphyatwork murphyatwork commented Jun 18, 2025 •
edited
Loading

Why I'm doing:

What I'm doing:

#48933 introduced an optimization for the INSERT-SELECT statement, significantly reducing the lock scope of the analyzer. This enhancement is particularly beneficial for external table data ingestion, where catalog access can be time-consuming.

Unfortunately, this optimization cannot currently be applied to SUBMIT TASK. Therefore, we aim to extend this optimization to SUBMIT TASK.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.5
    • 3.4
    • 3.3

@murphyatwork
extend the DEFER LOCK optimization to SUBMIT TASK
0a89b5e 
Signed-off-by: Murphy <mofei@starrocks.com>
@murphyatwork
fix submit task
24db826 
Signed-off-by: Murphy <mofei@starrocks.com>
@murphyatwork murphyatwork requested a review from a team as a code owner June 18, 2025 11:07
@meegoo meegoo enabled auto-merge (squash) June 18, 2025 18:38
@stephen-shelby
Copy link
Contributor

could you add some tests?

@murphyatwork
add test
388c70d 
Signed-off-by: Murphy <mofei@starrocks.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 20 / 20 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/analyzer/Analyzer.java 7 7 100.00% []
🔵 com/starrocks/sql/StatementPlanner.java 13 13 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@meegoo meegoo merged commit 06535fe into StarRocks:main Jun 20, 2025
71 of 72 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.5

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.5 label Jun 20, 2025
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.4

@mergify Mergify
Copy link
Contributor
mergify bot commented Jun 20, 2025 •
edited
Loading

backport branch-3.5

✅ Backports have been created

@mergify Mergify
Copy link
Contributor
mergify bot commented Jun 20, 2025 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor
mergify bot commented Jun 20, 2025 •
edited
Loading

backport branch-3.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 20, 2025
@murphyatwork @mergify
[BugFix] extend the DEFER LOCK optimization to SUBMIT TASK (#60026)
89733cf 
Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit 06535fe)
@mergify mergify bot mentioned this pull request Jun 20, 2025
Merged
22 tasks
mergify bot pushed a commit that referenced this pull request Jun 20, 2025
@murphyatwork @mergify
[BugFix] extend the DEFER LOCK optimization to SUBMIT TASK (#60026)
6800fa2 
Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit 06535fe)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/StatementPlanner.java
@mergify mergify bot mentioned this pull request Jun 20, 2025
Merged
22 tasks
mergify bot pushed a commit that referenced this pull request Jun 20, 2025
@murphyatwork @mergify
[BugFix] extend the DEFER LOCK optimization to SUBMIT TASK (#60026)
3917d13 
Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit 06535fe)
@mergify mergify bot mentioned this pull request Jun 20, 2025
Merged
22 tasks
murphyatwork added a commit that referenced this pull request Jun 20, 2025
@murphyatwork
[BugFix] extend the DEFER LOCK optimization to SUBMIT TASK (#60026)
1a6087c 
Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit 06535fe)
wanpengfei-git pushed a commit that referenced this pull request Jun 23, 2025
@mergify @murphyatwork
[BugFix] extend the DEFER LOCK optimization to SUBMIT TASK (backport #…
7626413 
…60026) (#60099)

Signed-off-by: Murphy <mofei@starrocks.com>
Co-authored-by: Murphy <96611012+murphyatwork@users.noreply.github.com>
murphyatwork added a commit that referenced this pull request Jun 23, 2025
@murphyatwork
[BugFix] extend the DEFER LOCK optimization to SUBMIT TASK (#60026)
34e66a6 
Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit 06535fe)
Signed-off-by: Murphy <mofei@starrocks.com>
murphyatwork added a commit that referenced this pull request Jun 23, 2025
@murphyatwork
[BugFix] extend the DEFER LOCK optimization to SUBMIT TASK (#60026)
fc87610 
Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit 06535fe)
Signed-off-by: Murphy <mofei@starrocks.com>
murphyatwork added a commit that referenced this pull request Jun 23, 2025
@murphyatwork
[BugFix] extend the DEFER LOCK optimization to SUBMIT TASK (#60026)
a9056c0 
Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit 06535fe)
Signed-off-by: Murphy <mofei@starrocks.com>
wanpengfei-git pushed a commit that referenced this pull request Jun 23, 2025
@mergify @murphyatwork
[BugFix] extend the DEFER LOCK optimization to SUBMIT TASK (backport #…
1fe7b95 
…60026) (#60100)

Signed-off-by: Murphy <mofei@starrocks.com>
Co-authored-by: Murphy <96611012+murphyatwork@users.noreply.github.com>
wanpengfei-git pushed a commit that referenced this pull request Jun 23, 2025
@mergify @murphyatwork
[BugFix] extend the DEFER LOCK optimization to SUBMIT TASK (backport #…
a93c420 
…60026) (#60101)

Signed-off-by: Murphy <mofei@starrocks.com>
Co-authored-by: Murphy <96611012+murphyatwork@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kangkaisen kangkaisen kangkaisen approved these changes

@stephen-shelby stephen-shelby stephen-shelby approved these changes

Assignees

@murphyatwork murphyatwork

Labels
3.3-merged 3.4-merged 3.5-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@murphyatwork @stephen-shelby @kangkaisen @meegoo
0