8000 [BugFix] Fix lowcardinality defineExpr error on union by Seaven · Pull Request #60075 · StarRocks/starrocks · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[BugFix] Fix lowcardinality defineExpr error on union #60075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2025
Merged

[BugFix] Fix lowcardinality defineExpr error on union #60075

merged 1 commit into from
Jun 20, 2025

Conversation

Seaven
Copy link
Contributor
@Seaven Seaven commented Jun 19, 2025 •
edited
Loading

Why I'm doing:

image

What I'm doing:

childFragmentUsedDictExpr used in multi children

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.5
    • 3.4
    • 3.3

@Seaven Seaven requested a review from a team as a code owner June 19, 2025 09:02
@mergify mergify bot assigned Seaven Jun 19, 2025
@Seaven
[BugFix] Fix union generate lowcardinality define expr error
41bd5b9 
Signed-off-by: Seaven <seaven_7@qq.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/rule/tree/lowcardinality/DecodeRewriter.java 1 1 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@kangkaisen kangkaisen merged commit 00cd75f into StarRocks:main Jun 20, 2025
139 of 143 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Jun 20, 2025
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.5

@mergify Mergify
Copy link
Contributor
mergify bot commented Jun 20, 2025 •
edited
Loading

backport branch-3.4

✅ Backports have been created

@mergify Mergify
Copy link
Contributor
mergify bot commented Jun 20, 2025 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor
mergify bot commented Jun 20, 2025 •
edited
Loading

backport branch-3.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 20, 2025
@Seaven @mergify
[BugFix] Fix lowcardinality defineExpr error on union (#60075)
aa0d5b7 
Signed-off-by: Seaven <seaven_7@qq.com>
(cherry picked from commit 00cd75f)
@mergify mergify bot mentioned this pull request Jun 20, 2025
Merged
22 tasks
mergify bot pushed a commit that referenced this pull request Jun 20, 2025
@Seaven @mergify
[BugFix] Fix lowcardinality defineExpr error on union (#60075)
e578d29 
Signed-off-by: Seaven <seaven_7@qq.com>
(cherry picked from commit 00cd75f)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/sql/plan/LowCardinalityTest2.java
@mergify mergify bot mentioned this pull request Jun 20, 2025
Closed
22 tasks
mergify bot pushed a commit that referenced this pull request Jun 20, 2025
@Seaven @mergify
[BugFix] Fix lowcardinality defineExpr error on union (#60075)
f4a3559 
Signed-off-by: Seaven <seaven_7@qq.com>
(cherry picked from commit 00cd75f)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/sql/plan/LowCardinalityTest2.java
@mergify mergify bot mentioned this pull request Jun 20, 2025
Merged
22 tasks
Seaven added a commit that referenced this pull request Jun 20, 2025
@Seaven
[BugFix] Fix lowcardinality defineExpr error on union (#60075)
ff5420d 
Signed-off-by: Seaven <seaven_7@qq.com>
(cherry picked from commit 00cd75f)
Seaven added a commit that referenced this pull request Jun 20, 2025
@Seaven
[BugFix] Fix lowcardinality defineExpr error on union (#60075)
b086cab 
Signed-off-by: Seaven <seaven_7@qq.com>
(cherry picked from commit 00cd75f)
wanpengfei-git pushed a commit that referenced this pull request Jun 20, 2025
@mergify @Seaven
[BugFix] Fix lowcardinality defineExpr error on union (backport #60075)…
197bd26 
… (#60128)

Signed-off-by: Seaven <seaven_7@qq.com>
Co-authored-by: Seaven <seaven_7@qq.com>
wanpengfei-git pushed a commit that referenced this pull request Jun 20, 2025
@mergify @Seaven
[BugFix] Fix lowcardinality defineExpr error on union (backport #60075)…
bb66772 
… (#60130)

Signed-off-by: Seaven <seaven_7@qq.com>
Co-authored-by: Seaven <seaven_7@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kangkaisen kangkaisen kangkaisen approved these changes

@stdpain stdpain stdpain approved these changes

Assignees

@Seaven Seaven

Labels
3.3-merged 3.5-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Seaven @kangkaisen @stdpain
0