[Refactor] rename aggregate/shared prefix to bundle #60057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: luohaha <18810541851@163.com>
ffb34c1 to
603817b
Compare
|
wyb
approved these changes
Jun 19, 2025
sevev
approved these changes
Jun 19, 2025
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 1 / 1 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 30 / 33 (90.91%) file detail
|
AntiTopQuark
pushed a commit
to AntiTopQuark/starrocks
that referenced
this pull request
Jun 19, 2025
Signed-off-by: luohaha <18810541851@163.com> Signed-off-by: AntiTopQuark <AntiTopQuark1350@outlook.com>
dengliu
pushed a commit
to dengliu/starrocks
that referenced
this pull request
Jun 20, 2025
Signed-off-by: luohaha <18810541851@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
In #58923 , we support file bundling for tablet meta, txnlog and segment files. The configuration to enable this optimization is defined as file_bundling, so variables and functions that previously used aggregate or shared as name prefixes in some places need to be changed to bundle to ensure consistency.
What I'm doing:
This pull request introduces a significant refactor across multiple files to replace the concept of "aggregate tablet metadata" with "bundle tablet metadata." The changes update method names, variable names, and associated logic throughout the codebase to align with the new terminology, ensuring consistency and improving clarity. Additionally, test cases have been updated to reflect this change.
Core Changes to Metadata Management:
be/src/storage/lake/tablet_manager.cpp: Replaced theput_aggregate_tablet_metadatamethod withput_bundle_tablet_metadata, updated logic to useBundleTabletMetadataPBinstead ofSharedTabletMetadataPB, and adjusted serialization/deserialization logic accordingly. [1] [2] [3] [4] [5] [6] [7] [8]be/src/storage/lake/tablet_manager.h: Updated method signatures to reflect the new terminology, includingbundle_tablet_metadata_location. [1] [2]Updates to Metadata Location Logic:
be/src/storage/lake/location_provider.h: Renamedaggregate_tablet_metadata_locationtobundle_tablet_metadata_locationto align with the refactor.Adjustments to Schema Change Handling:
be/src/storage/lake/schema_change.cpp: Replaced references toaggregate_tablet_metadatawithbundle_tablet_metadatain schema change logic.Test Updates:
be/test/storage/lake/alter_tablet_meta_test.cpp: Updated test cases to usebundle_tablet_metadatainstead ofaggr 8000 egate_tablet_metadata. [1] [2]be/test/storage/lake/tablet_manager_test.cpp: Refactored tests to validateput_bundle_tablet_metadatafunctionality. [1] [2]be/test/storage/lake/vacuum_test.cpp: Adjusted tests to ensure compatibility with the newbundle_tablet_metadatalogic. [1] [2] [3] [4]Miscellaneous Updates:
be/src/storage/lake/tablet_metadata.h: Introduced a new aliasBundleTabletMetadataPtrforBundleTabletMetadataPBto improve code readability.be/src/service/service_be/lake_service.cpp: Updated logging and task submission logic to reflect the new terminology.These changes ensure the codebase aligns with the updated metadata concept, improving clarity and maintainability.
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: