8000 [BugFix] Fix the `disk_device_id` function to aquire the device_id of an non-existent entry by its ancestor entries. by GavinMar · Pull Request #59919 · StarRocks/starrocks · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[BugFix] Fix the disk_device_id function to aquire the device_id of an non-existent entry by its ancestor entries. #59919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2025
Merged

[BugFix] Fix the disk_device_id function to aquire the device_id of an non-existent entry by its ancestor entries. #59919

merged 1 commit into from
Jun 17, 2025

Conversation

GavinMar
Copy link
Contributor

Why I'm doing:

We use the device_id to identify whether two disk paths locate in same disks.
The old disk_device_id function only aquires stats for the accurate path parameter, which may be not exist and cause the function failed.

What I'm doing:

Get the device_id of the given path from the current entry to its ancestor entries. If the current path does not exist, check its parent and ancestor entries.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.5
    • 3.4
    • 3.3

dirtysalt
dirtysalt previously approved these changes Jun 16, 2025
View reviewed changes
@GavinMar
[BugFix] Fix the disk_device_id function to aquire the device_id of an
6af8b72 
non-existent entry by its ancestor entries.

Signed-off-by: GavinMar <yangguansuo@starrocks.com>
trueeyu
trueeyu reviewed Jun 16, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 6 / 6 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/cache/datacache_utils.cpp 6 6 100.00% []

@dirtysalt dirtysalt merged commit 494aca6 into StarRocks:main Jun 17, 2025
77 of 78 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Jun 17, 2025
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.5

@github-actions github-actions bot removed the 3.5 label Jun 17, 2025
@mergify Mergify
Copy link
Contributor
mergify bot commented Jun 17, 2025 •
edited
Loading

backport branch-3.4

✅ Backports have been created

@mergify Mergify
Copy link
Contributor
mergify bot commented Jun 17, 2025 •
edited
Loading

backport branch-3.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 17, 2025
@GavinMar @mergify
[BugFix] Fix the disk_device_id function to aquire the device_id of…
7b63287 
… an non-existent entry by its ancestor entries. (#59919)

Signed-off-by: GavinMar <yangguansuo@starrocks.com>
(cherry picked from commit 494aca6)
@mergify mergify bot mentioned this pull request Jun 17, 2025
Merged
22 tasks
mergify bot pushed a commit that referenced this pull request Jun 17, 2025
@GavinMar @mergify
[BugFix] Fix the disk_device_id function to aquire the device_id of…
f7c0725 
… an non-existent entry by its ancestor entries. (#59919)

Signed-off-by: GavinMar <yangguansuo@starrocks.com>
(cherry picked from commit 494aca6)
@mergify mergify bot mentioned this pull request Jun 17, 2025
Merged
22 tasks
wanpengfei-git pushed a commit that referenced this pull request Jun 17, 2025
@mergify @GavinMar
[BugFix] Fix the disk_device_id function to aquire the device_id of…
137a40e 
… an non-existent entry by its ancestor entries. (backport #59919) (#59969)

Signed-off-by: GavinMar <yangguansuo@starrocks.com>
Co-authored-by: Gavin <yangguansuo@starrocks.com>
wanpengfei-git pushed a commit that referenced this pull request Jun 17, 2025
@mergify @GavinMar
[BugFix] Fix the disk_device_id function to aquire the device_id of…
e7a3f12 
… an non-existent entry by its ancestor entries. (backport #59919) (#59968)

Signed-off-by: GavinMar <yangguansuo@starrocks.com>
Co-authored-by: Gavin <yangguansuo@starrocks.com>
AntiTopQuark pushed a commit to AntiTopQuark/starrocks that referenced this pull request Jun 19, 2025
@GavinMar @AntiTopQuark
[BugFix] Fix the disk_device_id function to aquire the device_id of…
7c46ad1 
… an non-existent entry by its ancestor entries. (StarRocks#59919)

Signed-off-by: GavinMar <yangguansuo@starrocks.com>
Signed-off-by: AntiTopQuark <AntiTopQuark1350@outlook.com>
dengliu pushed a commit to dengliu/starrocks that referenced this pull request Jun 20, 2025
@GavinMar @dengliu
[BugFix] Fix the disk_device_id function to aquire the device_id of…
37ae794 
… an non-existent entry by its ancestor entries. (StarRocks#59919)

Signed-off-by: GavinMar <yangguansuo@starrocks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirtysalt dirtysalt dirtysalt approved these changes

@trueeyu trueeyu trueeyu approved these changes

Assignees

@GavinMar GavinMar

Labels
3.4-merged 3.5-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GavinMar @dirtysalt @trueeyu
0