10000 [BugFix] fix modify column wrongly handled for older version table (backport #59941) by mergify[bot] · Pull Request #59960 · StarRocks/starrocks · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[BugFix] fix modify column wrongly handled for older version table (backport #59941) #59960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2025
Merged

[BugFix] fix modify column wrongly handled for older version table (backport #59941) #59960

merged 1 commit into from
Jun 17, 2025

Conversation

mergify[bot]
Copy link
Contributor
@mergify mergify bot commented Jun 17, 2025 •
edited by wanpengfei-git
Loading

Why I'm doing:

What I'm doing:

need to pass columnId to CN when doing DDL

set up 3.1.13 cluster
create table t (id int, AAA varchar(10), dt date) 
DUPLICATE KEY(`id`)
partition by range(`dt`)
(PARTITION p20250507 VALUES [("2025-05-07"), ("2025-05-08")),
PARTITION p20250508 VALUES [("2025-05-08"), ("2025-05-09")),
PARTITION p20250509 VALUES [("2025-05-09"), ("2025-05-10")))
DISTRIBUTED BY HASH(`id`) buckets 1
properties (
'replication_num'='1'
);

insert into t values ('1','abc','2025-05-09 12:00:00');

select * from t;
AAA will be abc

upgrade to 3.3.14
alter table t modify column aaa varchar(100);

select * from t;
AAA will be NULL

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.5
    • 3.4
    • 3.3
This is an automatic backport of pull request #59941 done by [Mergify](https://mergify.com).

@starrocks-xupeng @mergify
[BugFix] fix modify column wrongly handled for older version table (#…
085eb47 
…59941)

Signed-off-by: starrocks-xupeng <xupeng@starrocks.com>
(cherry picked from commit 826f734)
@mergify mergify bot mentioned this pull request Jun 17, 2025
Merged
22 tasks
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) June 17, 2025 02:26
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@wanpengfei-git wanpengfei-git merged commit 427cfd3 into branch-3.5 Jun 17, 2025
48 of 49 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.5/pr-59941 branch June 17, 2025 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevincai kevincai kevincai approved these changes

Assignees

@starrocks-xupeng starrocks-xupeng

Labels
automerge version:3.5.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevincai @wanpengfei-git @starrocks-xupeng
0