8000 [Enhancement] Add more merge commit metrics by banmoy · Pull Request #58678 · StarRocks/starrocks · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Enhancement] Add more merge commit metrics #58678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[Enhancement] Add more merge commit metrics #58678

wants to merge 4 commits into from
+442 −121

Conversation

banmoy
Copy link
Contributor
@banmoy banmoy commented May 6, 2025 •
edited
Loading

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.5
    • 3.4
    • 3.3
    • 3.2
    • 3.1

@banmoy
Add merge commit FE metrics
8cb48b4 
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
@banmoy banmoy requested review from a team as code owners May 6, 2025 01:19
@banmoy banmoy changed the title [Enhancement] Add merge commit metrics [Enhancement] Add more merge commit metrics May 6, 2025
@mergify mergify bot assigned banmoy May 6, 2025
@banmoy
Add merge commit BE metrics
6599bd3 
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
@banmoy banmoy force-pushed the merge_commit_metrics branch from e24faa3 to 6599bd3 Compare May 6, 2025 01:24
banmoy added 2 commits May 6, 2025 09:47
@banmoy
fix typo
06ccad3 
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
@banmoy
fix test
dffa074 
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
@sonarqubecloud SonarQubeCloud
Copy link
sonarqubecloud bot commented May 6, 2025

Quality Gate Passed Quality Gate passed

Issues
11 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link
github-actions bot commented May 6, 2025

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link
github-actions bot commented May 6, 2025

[FE Incremental Coverage Report]

✅ pass : 425 / 444 (95.72%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/load/batchwrite/MergeCommitTask.java 202 213 94.84% [189, 190, 202, 203, 269, 283, 284, 285, 306, 316, 355]
🔵 com/starrocks/load/batchwrite/MergeCommitJob.java 102 108 94.44% [126, 207, 270, 279, 280, 281]
🔵 com/starrocks/load/batchwrite/MergeCommitMetricRegistry.java 81 83 97.59% [128, 129]
🔵 com/starrocks/metric/GaugeMetricImpl.java 3 3 100.00% []
🔵 com/starrocks/metric/MetricRepo.java 1 1 100.00% []
🔵 com/starrocks/load/batchwrite/TxnStateDispatcher.java 7 7 100.00% []
🔵 com/starrocks/load/batchwrite/BatchWriteMgr.java 13 13 100.00% []
🔵 com/starrocks/load/batchwrite/CoordinatorBackendAssignerImpl.java 16 16 100.00% []

@github-actions GitHub Actions
Copy link
github-actions bot commented May 6, 2025

[BE Incremental Coverage Report]

✅ pass : 48 / 50 (96.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/runtime/batch_write/isomorphic_batch_write.cpp 31 33 93.94% [289, 290]
🔵 be/src/runtime/batch_write/batch_write_mgr.cpp 1 1 100.00% []
🔵 be/src/runtime/batch_write/txn_state_cache.cpp 13 13 100.00% []
🔵 be/src/runtime/stream_load/time_bounded_stream_load_pipe.cpp 3 3 100.00% []

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-cr starrocks-cr[bot] starrocks-cr[bot] left review comments

@kevincai kevincai kevincai approved these changes

@gengjun-git gengjun-git gengjun-git approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@banmoy banmoy

Labels
3.4 3.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@banmoy @kevincai @gengjun-git
0