8000 [Doc] improve document of query profile by murphyatwork · Pull Request #58367 · StarRocks/starrocks · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Doc] improve document of query profile #58367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

murphyatwork
Copy link
Contributor
@murphyatwork murphyatwork commented Apr 24, 2025

Why I'm doing:

What I'm doing:

  1. Convert the metrics into tables
  2. Add diagnostic guidelines for SCAN, AGGREGATE, and JOIN operators.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.5
    • 3.4
    • 3.3
    • 3.2
    • 3.1

Signed-off-by: Murphy <mofei@starrocks.com>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 24, 2025
@DanRoscigno
Copy link
Contributor
DanRoscigno commented Apr 25, 2025

@murphyatwork in "Structure of Query Profile" Operator is mentioned several times, but I do not know what an Operator is. Will people reading this know what an Operator is, or should we define that?

I found it at the end:

Operator: This is a fundamental unit of execution in the Pipeline Engine. Each operator is responsible for implementing a specific algorithm, such as aggregation, join, or scan.

So, since this definition is so important, I will find a spot for it at the beginning unless you think everyone will know this.

I would like to copy this section to the top of the doc (still have it toward the end, but also at top so people have the background knowledge as they read the first half.

The Pipeline Engine is a key component of the StarRocks execution engine. It is responsible for executing the query plan in a parallel and efficient manner. The Pipeline Engine is designed to handle complex query plans and large volumes of data, ensuring high performance and scalability.

Concepts in the Pipeline Engine:

Operator: This is a fundamental unit of execution in the Pipeline Engine. Each operator is responsible for implementing a specific algorithm, such as aggregation, join, or scan.
Pipeline: A pipeline is a sequence of connected Operator instances. It represents the execution path of a query plan.
PipelineDriver: A pipeline is instantiated as multiple drivers to support data-parallel execution. Each driver is responsible for executing a portion of the pipeline in parallel.
Schedule: Pipelines are scheduled in a non-blocking manner, utilizing user-space time-slicing. Operators are designed to be non-blocking and CPU-intensive, while other threads handle blocking operations such as disk I/O and network I/O.

@DanRoscigno
Copy link
Contributor

@murphyatwork I am in the middle of edits and moving the wide tables to Markdown structure that fits on the screen. I will finish tomorrow my time

Good doc, I am learning a lot.

satanson
satanson previously approved these changes Apr 25, 2025
@murphyatwork
Copy link
Contributor Author

@murphyatwork in "Structure of Query Profile" Operator is mentioned several times, but I do not know what an Operator is. Will people reading this know what an Operator is, or should we define that?

I found it at the end:

Operator: This is a fundamental unit of execution in the Pipeline Engine. Each operator is responsible for implementing a specific algorithm, such as aggregation, join, or scan.

So, since this definition is so important, I will find a spot for it at the beginning unless you think everyone will know this.

I would like to copy this section to the top of the doc (still have it toward the end, but also at top so people have the background knowledge as they read the first half.

The Pipeline Engine is a key component 
8000
of the StarRocks execution engine. It is responsible for executing the query plan in a parallel and efficient manner. The Pipeline Engine is designed to handle complex query plans and large volumes of data, ensuring high performance and scalability.

Concepts in the Pipeline Engine:

Operator: This is a fundamental unit of execution in the Pipeline Engine. Each operator is responsible for implementing a specific algorithm, such as aggregation, join, or scan.
Pipeline: A pipeline is a sequence of connected Operator instances. It represents the execution path of a query plan.
PipelineDriver: A pipeline is instantiated as multiple drivers to support data-parallel execution. Each driver is responsible for executing a portion of the pipeline in parallel.
Schedule: Pipelines are scheduled in a non-blocking manner, utilizing user-space time-slicing. Operators are designed to be non-blocking and CPU-intensive, while other threads handle blocking operations such as disk I/O and network I/O.

Thank you for the suggestion. I'm also exploring ways to make it clearer. Perspectives from others are incredibly valuable.

@murphyatwork murphyatwork changed the title [Doc] improve document about query profile diagnostic [Doc] improve document of query profile Apr 25, 2025
Signed-off-by: DanRoscigno <dan@roscigno.com>
Signed-off-by: DanRoscigno <dan@roscigno.com>
@DanRoscigno
Copy link
Contributor

I pushed two commits @murphyatwork to 1) replace tables that were too wide 2) fix some spelling

Signed-off-by: DanRoscigno <dan@roscigno.com>
DanRoscigno
DanRoscigno previously approved these changes Apr 30, 2025
@DanRoscigno
Copy link
Contributor

Thanks so much for this @murphyatwork I learned a lot while reviewing it. I made some formatting changes, some of the tables were too wide so I converted them to lists. I also edited the other pages in the query profiles section.

The file I removed, index.html, was causing problems unrelated to your PR (when I upgraded Docusaurus the other day it broke some functionality related to reviewing PRs, so I removed the file to review your PR)

Signed-off-by: DanRoscigno <dan@roscigno.com>
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@alvin-celerdata alvin-celerdata merged commit 8a645dd into StarRocks:main Apr 30, 2025
54 checks passed
Copy link

@Mergifyio backport branch-3.4

Copy link

@Mergifyio backport branch-3.5

Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Apr 30, 2025
Copy link
Contributor
mergify bot commented Apr 30, 2025

backport branch-3.4

✅ Backports have been created

Copy link
Contributor
mergify bot commented Apr 30, 2025

backport branch-3.5

✅ Backports have been created

Copy link
Contributor
mergify bot commented Apr 30, 2025

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 30, 2025
Signed-off-by: Murphy <mofei@starrocks.com>
Signed-off-by: DanRoscigno <dan@roscigno.com>
Co-authored-by: DanRoscigno <dan@roscigno.com>
(cherry picked from commit 8a645dd)
mergify bot pushed a commit that referenced this pull request Apr 30, 2025
Signed-off-by: Murphy <mofei@starrocks.com>
Signed-off-by: DanRoscigno <dan@roscigno.com>
Co-authored-by: DanRoscigno <dan@roscigno.com>
(cherry picked from commit 8a645dd)
mergify bot pushed a commit that referenced this pull request Apr 30, 2025
Signed-off-by: Murphy <mofei@starrocks.com>
Signed-off-by: DanRoscigno <dan@roscigno.com>
Co-authored-by: DanRoscigno <dan@roscigno.com>
(cherry picked from commit 8a645dd)
wanpengfei-git pushed a commit that referenced this pull request Apr 30, 2025
Signed-off-by: Murphy <mofei@starrocks.com>
Signed-off-by: DanRoscigno <dan@roscigno.com>
Co-authored-by: Murphy <96611012+murphyatwork@users.noreply.github.com>
Co-authored-by: DanRoscigno <dan@roscigno.com>
wanpengfei-git pushed a commit that referenced this pull request Apr 30, 2025
Signed-off-by: Murphy <mofei@starrocks.com>
Signed-off-by: DanRoscigno <dan@roscigno.com>
Co-authored-by: Murphy <96611012+murphyatwork@users.noreply.github.com>
Co-authored-by: DanRoscigno <dan@roscigno.com>
wanpengfei-git pushed a commit that referenced this pull request Apr 30, 2025
Signed-off-by: Murphy <mofei@starrocks.com>
Signed-off-by: DanRoscigno <dan@roscigno.com>
Co-authored-by: Murphy <96611012+murphyatwork@users.noreply.github.com>
Co-authored-by: DanRoscigno <dan@roscigno.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.3-merged 3.4-merged 3.5-merged documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0