8000 [Enhancement]support decompressed page cache for parquet by zombee0 · Pull Request #58197 · StarRocks/starrocks · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Enhancement]support decompressed page cache for parquet #58197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 29, 2025
Merged

[Enhancement]support decompressed page cache for parquet #58197

merged 8 commits into from
Apr 29, 2025

Conversation

zombee0
Copy link
Contributor
@zombee0 zombee0 commented Apr 18, 2025

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.5
    • 3.4
    • 3.3
    • 3.2
    • 3.1

@zombee0 zombee0 requested review from a team as code owners April 18, 2025 11:45
@wanpengfei-git wanpengfei-git requested a review from a team April 18, 2025 11:45
@zombee0 zombee0 force-pushed the mem_page_cache_lake branch 4 times, most recently from 8b511b1 to 1863281 Compare April 27, 2025 10:41
@zombee0 zombee0 requested a review from a team as a code owner April 27, 2025 10:41
@zombee0 zombee0 force-pushed the mem_page_cache_lake branch 2 times, most recently from 3bff6f2 to 250a19b Compare April 28, 2025 01:56
dirtysalt
dirtysalt previously approved these changes Apr 28, 2025
View reviewed changes
@zombee0 zombee0 force-pushed the mem_page_cache_lake branch from 0287379 to 5a279f3 Compare April 28, 2025 07:07
zombee0 added 7 commits April 28, 2025 15:40
@zombee0
[Enhancement]support decompressed page cache for parquet
eabacf6 
Signed-off-by: zombee0 <ewang2027@gmail.com>
@zombee0
ut
35c4cf9 
Signed-off-by: zombee0 <ewang2027@gmail.com>
@zombee0
catch exception
80911b3 
Signed-off-by: zombee0 <ewang2027@gmail.com>
@zombee0
skip DCHECK
8e2304e 
Signed-off-by: zombee0 <ewang2027@gmail.com>
@zombee0
checkpoint
78c1c0b 
Signed-off-by: zombee0 <ewang2027@gmail.com>
@zombee0
more
0e537d9 
Signed-off-by: zombee0 <ewang2027@gmail.com>
@zombee0
fix metrics
4dd4c74 
Signed-off-by: zombee0 <ewang2027@gmail.com>
@zombee0 zombee0 force-pushed the mem_page_cache_lake branch from 5a279f3 to 578f993 Compare April 28, 2025 07:42
@zombee0
add parquet_page_cache_decompress_threshold
0ad3ee6 
Signed-off-by: zombee0 <ewang2027@gmail.com>
@zombee0 zombee0 force-pushed the mem_page_cache_lake branch from faed933 to 0ad3ee6 Compare April 28, 2025 07:50
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 2 / 2 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/qe/SessionVariable.java 2 2 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 222 / 236 (94.07%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/formats/parquet/file_reader.cpp 8 12 66.67% [355, 356, 357, 358]
🔵 be/src/formats/parquet/utils.cpp 12 15 80.00% [148, 149, 152]
🔵 be/src/formats/parquet/page_reader.cpp 161 168 95.83% [170, 171, 172, 177, 178, 179, 258]
🔵 be/src/runtime/exec_env.h 1 1 100.00% []
🔵 be/src/formats/parquet/column_chunk_reader.cpp 6 6 100.00% []
🔵 be/src/formats/parquet/metadata.cpp 2 2 100.00% []
🔵 be/src/connector/hive_connector.cpp 6 6 100.00% []
🔵 be/src/formats/parquet/page_reader.h 2 2 100.00% []
🔵 be/src/exec/hdfs_scanner.cpp 1 1 100.00% []
🔵 be/src/formats/parquet/group_reader.cpp 4 4 100.00% []
🔵 be/src/exec/hdfs_scanner_parquet.cpp 19 19 100.00% []

@dirtysalt dirtysalt merged commit 71412e8 into StarRocks:main Apr 29, 2025
60 checks passed
@zombee0
Copy link
Contributor Author
zombee0 commented May 7, 2025

https://github.com/Mergifyio backport branch-3.5

@mergify Mergify
Copy link
Contributor
mergify bot commented May 7, 2025 •
edited
Loading

backport branch-3.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 7, 2025
@zombee0 @mergify
[Enhancement]support decompressed page cache for parquet (#58197)
b5a083f 
Signed-off-by: zombee0 <ewang2027@gmail.com>
(cherry picked from commit 71412e8)

# Conflicts:
#	be/src/connector/hive_connector.cpp
#	be/src/formats/parquet/column_chunk_reader.cpp
#	be/src/formats/parquet/column_chunk_reader.h
#	be/src/formats/parquet/file_reader.cpp
#	be/src/formats/parquet/page_reader.cpp
#	gensrc/thrift/InternalService.thrift
@mergify mergify bot mentioned this pull request May 7, 2025
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshishki eshishki eshishki left review comments

@dirtysalt dirtysalt dirtysalt approved these changes

@trueeyu trueeyu trueeyu approved these changes

Assignees

@zombee0 zombee0

Labels
PROTO-REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zombee0 @dirtysalt @trueeyu @eshishki @wanpengfei-git
0