8000 Pants: add dependencies to the st2* `python_distributions` (except st2common/st2tests) by cognifloyd · Pull Request #5928 · StackStorm/st2 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Pants: add dependencies to the st2* python_distributions (except st2common/st2tests) #5928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 10, 2023
Merged

Pants: add dependencies to the st2* python_distributions (except st2common/st2tests) #5928

merged 3 commits into from
Mar 10, 2023

Conversation

cognifloyd
Copy link
Member
@cognifloyd cognifloyd commented Mar 9, 2023 •
edited
Loading

Background

This is another part of introducing pants, as discussed in various TSC meetings.

Related PRs can be found in:

Overview of this PR

Like #5925, which adds dependencies for the python_distribution for st2common, this PR adds the remaining dependencies for the other st2* component python_distribution targets. It also skips st2tests which requires quite a few more changes in #5929.

It also adds a note to pants.toml to make it clear that pants will generate a setup.py file for us.

Pants documentation

@cognifloyd cognifloyd added this to the pants milestone Mar 9, 2023
@cognifloyd cognifloyd requested review from winem, arm4b, nzlosh, rush-skills, amanda11 and a team March 9, 2023 23:20
@cognifloyd cognifloyd self-assigned this Mar 9, 2023
@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines. Good size to review. label Mar 9, 2023
@cognifloyd cognifloyd changed the title Pants: add dependencies to the st2* python_distributions (except st2common) Pants: add dependencies to the st2* python_distributions (except st2common/st2tests) Mar 9, 2023
@cognifloyd cognifloyd changed the title Pants: add dependencies to the st2* python_distributions (except st2common/st2tests) Pants: add dependencies to the st2* python_distributions (except st2common/st2tests) Mar 9, 2023
@cognifloyd cognifloyd marked this pull request as draft March 9, 2023 23:25
@cognifloyd cognifloyd force-pushed the pants-python_distributions-deps-2 branch from 63378c9 to 1b90c02 Compare March 10, 2023 01:45
cognifloyd
cognifloyd commented Mar 10, 2023
View reviewed changes
st2api/st2api/BUILD
# controller routes are wired up via st2common/st2common/openapi.yaml
"./controllers",
"./controllers/v1",
# "./controllers/exp",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No APIs are in the experimental folder right now. So, I left this commented out.

@cognifloyd cognifloyd marked this pull request as ready for review March 10, 2023 02:08
This was referenced Mar 10, 2023
Merged
Merged
@cognifloyd cognifloyd requested a review from a team March 10, 2023 08:20
@cognifloyd cognifloyd enabled auto-merge March 10, 2023 16:50
@cognifloyd cognifloyd force-pushed the pants-python_distributions-deps-2 branch from 1b90c02 to 43ca9ad Compare March 10, 2023 17:01
@cognifloyd cognifloyd force-pushed the pants-python_distributions-deps-2 branch from 43ca9ad to 2678cba Compare March 10, 2023 17:11
@cognifloyd cognifloyd merged commit 1c36c97 into master Mar 10, 2023
@cognifloyd cognifloyd deleted the pants-python_distributions-deps-2 branch March 10, 2023 17:50
@cognifloyd cognifloyd mentioned this pull request Mar 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nzlosh nzlosh nzlosh approved these changes

@rush-skills rush-skills rush-skills approved these changes

@winem winem Awaiting requested review from winem

@arm4b arm4b Awaiting requested review from arm4b

@amanda11 amanda11 Awaiting requested review from amanda11

Assignees

@cognifloyd cognifloyd

Labels
pantsbuild size/M PR that changes 30-99 lines. Good size to review.
Projects
None yet
Milestone
pants
Development

Successfully merging this pull request may close these issues.
3 participants
@cognifloyd @nzlosh @rush-skills
0