8000 Add RBAC permission types for key value pairs by m4dcoder · Pull Request #5368 · StackStorm/st2 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add RBAC permission types for key value pairs #5368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 22, 2021
Merged

Add RBAC permission types for key value pairs #5368

merged 3 commits into from
Sep 22, 2021

Conversation

m4dcoder
Copy link
Contributor

Add RBAC permission types for key value pairs so the changes at StackStorm/st2-rbac-backend#55 to introduce RBAC to KVP can pass CI.

@m4dcoder
Add RBAC permission types for key value pairs
1cfc811 
Add RBAC permission types for key value pairs so the changes at
StackStorm/st2-rbac-backend#55 to introduce RBAC
to KVP can pass CI.
@pull-request-size pull-request-size bot added the size/XS PR that changes 0-9 lines. Quick fix/merge. label Sep 22, 2021
@m4dcoder m4dcoder added this to the 3.6.0 milestone Sep 22, 2021
amanda11
amanda11 requested changes Sep 22, 2021
View reviewed changes
Copy link
Contributor
@amanda11 amanda11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the new permission types be added either to the resource type they belong to, or to global permission array if they are global types?
At moment I don't think they are in either so can't be used.

@m4dcoder
Add resource type to permission type and help text
9be8c5d 
Add resource type to permission type for key value pair permissions.
Add help text to the new key value pair permission types.
@m4dcoder
Copy link
Contributor Author

I added to the resource type to permission type map. The global permission type dynamically applies the list permission.

amanda11
amanda11 approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor
@amanda11 amanda11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just a minor reword required - but approved so can be merged after that is fixed.

@cognifloyd cognifloyd merged commit 590a297 into master Sep 22, 2021
@cognifloyd cognifloyd deleted the prep-rbac-kvp branch September 22, 2021 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cognifloyd cognifloyd cognifloyd approved these changes

@amanda11 amanda11 amanda11 approved these changes

Assignees
No one assigned
Labels
size/XS PR that changes 0-9 lines. Quick fix/merge.
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@m4dcoder @cognifloyd @amanda11
0