8000 Remove flaky tiktoken test by mrubens · Pull Request #3113 · RooVetGit/Roo-Code · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove flaky tiktoken test #3113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2025
Merged

Remove flaky tiktoken test #3113

merged 1 commit into from
May 2, 2025

Conversation

mrubens
Copy link
Collaborator
@mrubens mrubens commented May 2, 2025 •
edited by ellipsis-dev bot
Loading

Important

Remove unreliable performance timing test from tiktoken.test.ts due to system load variations.

  • Tests:
    • Remove flaky performance timing test in tiktoken.test.ts that compared encoder reuse times, which was unreliable due to system load variations.
    • Ensure remaining tests in tiktoken.test.ts still cover core functionality of tiktoken function, such as token counting for text and image content.

This description was created by Ellipsis for afabe70. You can customize this summary. It will automatically update as commits are pushed.

@mrubens mrubens requested a review from cte as a code owner May 2, 2025 04:35
@changeset-bot changeset-bot
Copy link
changeset-bot bot commented May 2, 2025

⚠️ No Changeset found

Latest commit: afabe70

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label May 2, 2025
cte
cte approved these changes May 2, 2025
View reviewed changes
Copy link
Collaborator
@cte cte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you - was meaning to do this.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 2, 2025
@mrubens mrubens merged commit f813ed8 into main May 2, 2025
19 checks passed
@mrubens mrubens deleted the remove_flaky_tiktoken_test branch May 2, 2025 04:40
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cte cte cte approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
Roo Code Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrubens @cte
0