-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Auto Approved Sub Tasks Hang #3107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @timthesinner! I'm Dosu, here to help you with bugs, questions, and becoming a contributor. I'm ready to assist you while you wait for a human maintainer. Let's get started! The issue you're experiencing with the workflow hanging during subtask auto-approval might be related to how the system handles subtask completion and return to the parent task. There is a known issue where workflows hang due to improper handling of subtask cancellation, which might be related to your problem. Specifically, the Additionally, the auto-approval feature has undergone recent changes, such as the introduction of an auto-approval toggle for subtask creation and completion, which might be affecting the workflow [2][3]. It could be beneficial to check if these changes are impacting your setup. If this issue persists, consider checking for any updates or patches that might address this behavior in the latest version of Roo Code. To continue talking to Dosu, mention @dosu. Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Bug Report | Other |
I was able to confirm that issue does not exist on This is not an issue with cancellation of the task, the sub task was completed successfully. It just seems that on the latest version, when that subtask completes the workflow hangs, like it is looking for the user to click the button (but as you can see in the picture the buttons and chat input are disabled) Obviously I would prefer the AI to just complete the sub task and proceed as I am not expecting to review every minor change, I want to review the overall PR |
I've had similar happen to me but I'm not sure if it's exactly the same because so far I think it's only happened to me when the last task is a failed python unit test: The result is the same though: Roo becomes soft-locked and I have to close the task and start a new one. EDIT: I just had it happen again when running "python -m pytest", however this was a successful test, not a failure. |
I have had the same issue three times today, sub task tells me "Roo wants to finish this subtask", it then ask me to confirm that everything looks good, so that it can return to the parent task. |
For me, this exact issue appears to be occuring because there are edits still in-progress (but that, of course, aren't actually happening) earlier in the chain history: My current workaround is to copy the Here is the `attempt_completion` result:
```txt
<pasted result>
``` |
Does rolling back to 3.15.1 fix for you all? Trying to narrow down the version where this started happening - I'm struggling to repro. |
I am thinking that does fix it. It seems that way. |
Thanks, I think this could be related to subtasks trying to run commands as part of completion. @cte and I are taking a look. Thank you all for the help. |
I am still getting this issue for the same root cause in 3.15.1, although MUCH less frequently. |
Can you try 3.15.4? We released a hopeful fix. |
Let us know if this is still an issue. if it is I will reopen. |
App Version
v3.15.1
API Provider
OpenRouter
Model Used
All Models
Actual vs. Expected Behavior
When the AI is allowed to auto complete sub tasks the workflow hangs at user approval (that is unneeded).
Orchestrators are able to auto submit sub tasks without issue, it is the subtask return that is having problems.
When auto complete sub task is not active, the workflow ends and you can click a button to head back to the orchestrator. While it is hung the only thing you can do is terminate the task by exiting out which tells the orchestrator that the task failed.
Detailed Steps to Reproduce
Relevant API Request Output
Additional Context
No response
The text was updated successfully, but these errors were encountered: