8000 Auto Approved Sub Tasks Hang · Issue #3107 · RooVetGit/Roo-Code · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Auto Approved Sub Tasks Hang #3107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
timthesinner opened this issue May 2, 2025 · 14 comments
Closed

Auto Approved Sub Tasks Hang #3107

timthesinner opened this issue May 2, 2025 · 14 comments
Labels
8000 bug Something isn't working

Comments

@timthesinner
Copy link

App Version

v3.15.1

API Provider

OpenRouter

Model Used

All Models

Actual vs. Expected Behavior

When the AI is allowed to auto complete sub tasks the workflow hangs at user approval (that is unneeded).

Orchestrators are able to auto submit sub tasks without issue, it is the subtask return that is having problems.

When auto complete sub task is not active, the workflow ends and you can click a button to head back to the orchestrator. While it is hung the only thing you can do is terminate the task by exiting out which tells the orchestrator that the task failed.

Image

Detailed Steps to Reproduce

  1. Activate subtask auto approval
  2. Give an orchestrator a task to break down
  3. Let that orchestrator delegate a task to a different mode
  4. Wait for that mode to complete which will hang the workflow

Relevant API Request Output

Additional Context

No response

@timthesinner timthesinner added the bug Something isn't working label May 2, 2025
Copy link
dosubot bot commented May 2, 2025

Hi @timthesinner! I'm Dosu, here to help you with bugs, questions, and becoming a contributor. I'm ready to assist you while you wait for a human maintainer. Let's get started!

The issue you're experiencing with the workflow hanging during subtask auto-approval might be related to how the system handles subtask completion and return to the parent task. There is a known issue where workflows hang due to improper handling of subtask cancellation, which might be related to your problem. Specifically, the cancelTask() method in ClineProvider.ts does not properly handle subtask cancellation, causing the parent task to remain paused indefinitely [1].

Additionally, the auto-approval feature has undergone recent changes, such as the introduction of an auto-approval toggle for subtask creation and completion, which might be affecting the workflow [2][3]. It could be beneficial to check if these changes are impacting your setup.

If this issue persists, consider checking for any updates or patches that might address this behavior in the latest version of Roo Code.

To continue talking to Dosu, mention @dosu.


Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Bug Report | Other

@timthesinner
Copy link
Author

I was able to confirm that issue does not exist on v3.14.3 by manually rolling back.

This is not an issue with cancellation of the task, the sub task was completed successfully. It just seems that on the latest version, when that subtask completes the workflow hangs, like it is looking for the user to click the button (but as you can see in the picture the buttons and chat input are disabled)

Obviously I would prefer the AI to just complete the sub task and proceed as I am not expecting to review every minor change, I want to review the overall PR

@redlotusaustin
Copy link
redlotusaustin commented May 2, 2025

I've had similar happen to me but I'm not sure if it's exactly the same because so far I think it's only happened to me when the last task is a failed python unit test:

Image

The result is the same though: Roo becomes soft-locked and I have to close the task and start a new one.

EDIT: I just had it happen again when running "python -m pytest", however this was a successful test, not a failure.

@SaigonMike
Copy link

I have had the same issue three times today, sub task tells me "Roo wants to finish this subtask", it then ask me to confirm that everything looks good, so that it can return to the parent task.
There is no way to confirm as the input field is disabled and Subtasks are set to auto. This is happening on the same task 3 times in a row.

@DavidBoman
Copy link

+1

Image

@sealad886
Copy link 8000

For me, this exact issue appears to be occuring because there are edits still in-progress (but that, of course, aren't actually happening) earlier in the chain history:

Image

My current workaround is to copy the attempt_completion output displayed by the subtask, "terminate" the task (using the X at the top right), then cancel the step in the parent task when it says "the user terminated the subtask" and say something like:

Here is the `attempt_completion` result:

```txt
<pasted result>
```

@mrubens
Copy link
Collaborator
mrubens commented May 3, 2025

Does rolling back to 3.15.1 fix for you all? Trying to narrow down the version where this started happening - I'm struggling to repro.

@robertheadley
Copy link

I am thinking that does fix it. It seems that way.

@mrubens
Copy link
Collaborator
mrubens commented May 4, 2025

Thanks, I think this could be related to subtasks trying to run commands as part of completion. @cte and I are taking a look. Thank you all for the help.

@redlotusaustin
Copy link

That does seem to be the problem for me. The task shows as completed in this screenshot, then coverage tests run and it hangs:

Image

Thank you for all of your hard work!

@sealad886
Copy link

I am still getting this issue for the same root cause in 3.15.1, although MUCH less frequently.

@kokorolx
Copy link
kokorolx commented May 4, 2025

I'm facing same issue, while it complete the subtask but can not return to parent task.
I'm using Version: 3.15.3
Image

@mrubens
Copy link
Collaborator
mrubens commented May 4, 2025

Can you try 3.15.4? We released a hopeful fix.

@hannesrudolph
Copy link
Collaborator

Let us know if this is still an issue. if it is I will reopen.

@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap May 5, 2025
SmartManoj pushed a commit to SmartManoj/Roo-Code that referenced this issue May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

9 participants
0