Revert "Experimental onBackpressureBufferWithCapacity" #1918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjchristensen
added a commit
that referenced
this pull request
Dec 2, 2014
…kpressureBufferWithCapacity Revert "Experimental onBackpressureBufferWithCapacity"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1916
This breaks unit tests all over for some reason. I completely missed it before merging as the unit tests related to
onBackpressureBufferthemselves pass. It's elsewhere that things break.From what I can tell it is because
onBackpressureBufferis used in unit tests and those fail (often with timeouts or what appears to be infinite loops ... since my CPU pegs itself).