feat: implement /node/identity endpoint
#269
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KolbyML
reviewed
Apr 3, 2025
There was a problem hiding this comment.
This doesn't belong in the network spec crate
KolbyML
requested changes
Apr 3, 2025
I marked the PR as a draft, as I don't think there is value in adding this endpoint until we can add it in a working state without mock data. |
|
Hi we recently migrated from using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #177
To run, start a node:
Make
GETrequest to:Note: The
metadatafield gives dummy values now, this will be updated once we addattnetsand other related networking fields