Added an option to follow symlinks #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks mate, I actually made this the default. It seems semantically correct to always follow symlinks. If this comes back and bites people, I'll add in a -F / --nofollowsymlinks style option. 😅 🤞 |
|
Also thank you for your patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the
os.walkfunction from Python does not follow symlinks, and so running whatmp3 against directories containing symlinks is unsuccessful.This simple PR includes a new option for whatmp3,
-f, which causes it to passfollowlinks=Trueto theos.walkfunction, allowing whatmp3 to follow symlinks in operating systems which support them.