8000 Add support for complex vectors to CJ, part of #3690 by MichaelChirico · Pull Request #3691 · Rdatatable/data.table · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add support for complex vectors to CJ, part of #3690 #3691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 16, 2019
Merged

Conversation

MichaelChirico
Copy link
Member

#3690

Low-hanging fruit

@codecov
Copy link
codecov bot commented Jul 10, 2019

Codecov Report

Merging #3691 into master will decrease coverage by <.01%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3691      +/-   ##
==========================================
- Coverage   98.25%   98.25%   -0.01%     
==========================================
  Files          69       69              
  Lines       13088    13097       +9     
==========================================
+ Hits        12860    12868       +8     
- Misses        228      229       +1
Impacted Files Coverage Δ
src/cj.c 98.43% <88.88%> (-1.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e3868b...9cc2529. Read the comment docs.

@codecov
Copy link
codecov bot commented Jul 10, 2019

Codecov Report

Merging #3691 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3691      +/-   ##
==========================================
+ Coverage   98.25%   98.25%   +<.01%     
==========================================
  Files          69       69              
  Lines       13084    13093       +9     
==========================================
+ Hits        12856    12865       +9     
  Misses        228      228
Impacted Files Coverage Δ
src/cj.c 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 383a741...0a7aab7. Read the comment docs.

@mattdowle mattdowle added this to the 1.12.4 milestone Jul 16, 2019
@mattdowle mattdowle merged commit d3e146d into master Jul 16, 2019
@mattdowle mattdowle deleted the cplx_cj branch July 16, 2019 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0