10000 1.9.1: Interval does not match 'cube enclosing the unit sphere'. · Issue #1603 · RayTracing/raytracing.github.io · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

1.9.1: Interval does not match 'cube enclosing the unit sphere'. #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
whydoubt opened this issue Aug 16, 2024 · 3 comments
Closed

1.9.1: Interval does not match 'cube enclosing the unit sphere'. #1603

whydoubt opened this issue Aug 16, 2024 · 3 comments
Labels
area: book book 1: One Weekend level: patch
Milestone
v4.0.1

Comments

@whydoubt
Copy link
Contributor

In #1591, text was changed from 'unit cube' to 'cube enclosing the unit sphere' to correctly describe the cube.
At the same time, the range was changed to interval notation, and the values were changed (from -1 and +1 to 0 and 1).
While I like the use of interval notation here, the values are now incorrect.
x/y/z in the range [-1,1] is the actual range for a cube enclosing the unit sphere.
x/y/z in the range [0,1] is (ironically?) a unit cube.
@hollasch
Copy link
Collaborator

Yup, the range should be $[-1,+1]$. Let me know if you want to make the PR, or I can do it.

@hollasch hollasch added this to the v4.0.1 milestone Aug 17, 2024
@whydoubt
Copy link
Contributor Author

You can go ahead with this one, I'm away from my workstation for a bit.

@hollasch
8000
Copy link
Collaborator

Will do; thanks.

hollasch added a commit that referenced this issue Aug 17, 2024
@hollasch
Fix text around unit sphere random pt generation
cb378ca 
Resolves #1603
@hollasch hollasch mentioned this issue Aug 17, 2024
Merged
hollasch added a commit that referenced this issue Aug 18, 2024
@hollasch
Fix text around unit sphere random pt generation
fe3385b 
Resolves #1603
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: book book 1: One Weekend level: patch
Projects
None yet
Milestone
v4.0.1
Development

No branches or pull requests
2 participants
@hollasch @whydoubt
0